Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#130 2026-04-17 21:56:35 +02:00
feat(atlas): Gemma 4 naming pipeline + 24,963 named features (#833)

Review: sprint-35/server -> main (type: code + content)

Reviewers: Hoshe (code quality), Tyre (architecture), Miri (world consistency + statistics), Paula (narrative depth + statistics)


jpmschweitzer created pull request jpmschweitzer/settled-reach#130 2026-04-17 18:48:01 +02:00
feat(atlas): Gemma 4 naming pipeline + 24,963 named features (#833)
jpmschweitzer pushed to sprint-35/server at jpmschweitzer/settled-reach 2026-04-17 18:46:57 +02:00
9aaaf95742 content(atlas): name 24,963 features across 299 systems via Gemma 4 pipeline (#833)
508d6a7ca9 docs(architecture): atlas naming pipeline reference (#833)
9ad9b88d7c feat(tooling): Gemma 4 batch naming pipeline with wiki-grounded register selection (#833)
474b31b214 fix(tooling): only log rejections when all attempts exhausted (#833)
b63c2be8dd feat(tooling): 5 retry attempts + refresh every 1000 requests (#833)
Compare 31 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-15 10:39:01 +02:00
d388845c88 chore(config): prune dead gitignore entries
84bb10234e chore(config): allow cargo clippy and ruff check in Bash permissions
Compare 2 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#129 2026-04-15 09:36:34 +02:00
feat(server): Sprint 35 — seed, brand layer, terrain refs, atlas pipeline
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-15 09:36:32 +02:00
8d8fa9060f Merge remote-tracking branch 'origin/sprint-35/server'
d21c690293 fix(tooling): address PR #129 review — atlas generator, schema, Makefile
64bb83f749 fix(simulation): address PR #129 review — brand importer hardening
56d524f37d docs(decisions): address PR #129 review — D-191 §8 amendment + boundary notes
5619218e31 feat(tooling): generate_atlas.py city + infrastructure pipeline and atlas DB index (#832)
Compare 10 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#129 2026-04-15 09:34:25 +02:00
feat(server): Sprint 35 — seed, brand layer, terrain refs, atlas pipeline

PR Review Round 2 — sprint-35/server → main

Reviewers: Hoshe (code quality), Tyre (architecture) Verdict: APPROVED (2/2)

Fix commit chain (`56d524f3 docs/§8 amendment → 64bb83f7…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#129 2026-04-15 09:26:54 +02:00
feat(server): Sprint 35 — seed, brand layer, terrain refs, atlas pipeline

Review fixes pushed — 3 commits

56d524f3 docs(decisions) • 64bb83f7 fix(simulation) • d21c6902 fix(tooling)

Blockers

jpmschweitzer pushed to sprint-35/server at jpmschweitzer/settled-reach 2026-04-15 09:25:57 +02:00
d21c690293 fix(tooling): address PR #129 review — atlas generator, schema, Makefile
64bb83f749 fix(simulation): address PR #129 review — brand importer hardening
56d524f37d docs(decisions): address PR #129 review — D-191 §8 amendment + boundary notes
Compare 3 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#128 2026-04-15 09:16:57 +02:00
feat(ui): Sprint 35 — Atlas of the Reach (Phase 3 planetary viewer)
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-15 09:16:55 +02:00
57e52d7586 Merge remote-tracking branch 'origin/sprint-35/client'
22c17f1f15 style(ui): gdformat atlas implant files
489aec48d8 style(ui): atlas review polish — guarded ids, stable keys, dead-code cleanup (#128)
f8b81e1fe7 refactor(ui): atlas review warnings — headers, public API, KEY_N, overlay source of truth (#128)
1328db3138 fix(ui): atlas review blockers — moon layout, stale grid dims, overlay schema (#128)
Compare 9 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#128 2026-04-15 09:15:30 +02:00
feat(ui): Sprint 35 — Atlas of the Reach (Phase 3 planetary viewer)

PR Review Round 2 — sprint-35/client → main

Reviewers: Hoshe (code quality), Tyre (architecture) Verdict: APPROVED (2/2)

Fix commit chain (`1328db31 fix → f8b81e1f refactor →…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#129 2026-04-15 09:08:19 +02:00
feat(server): Sprint 35 — seed, brand layer, terrain refs, atlas pipeline

PR Review — sprint-35/server → main (2-reviewer consolidated + team-lead spot checks)

Reviewers: Hoshe (code quality), Tyre (architecture) Spot checks: batch schema scan, hand-authore…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#128 2026-04-15 09:08:18 +02:00
feat(ui): Sprint 35 — Atlas of the Reach (Phase 3 planetary viewer)

Review response — blockers + warnings + polish all addressed

Pushed four follow-up commits in the order the review laid them out. Pre-flight on the current branch is clean: gdlint zero,…

jpmschweitzer pushed to sprint-35/client at jpmschweitzer/settled-reach 2026-04-15 09:06:16 +02:00
22c17f1f15 style(ui): gdformat atlas implant files
jpmschweitzer pushed to sprint-35/client at jpmschweitzer/settled-reach 2026-04-15 09:02:45 +02:00
489aec48d8 style(ui): atlas review polish — guarded ids, stable keys, dead-code cleanup (#128)
f8b81e1fe7 refactor(ui): atlas review warnings — headers, public API, KEY_N, overlay source of truth (#128)
1328db3138 fix(ui): atlas review blockers — moon layout, stale grid dims, overlay schema (#128)
Compare 3 commits »
jpmschweitzer created pull request jpmschweitzer/settled-reach#129 2026-04-15 08:53:27 +02:00
feat(server): Sprint 35 — seed, brand layer, terrain refs, atlas pipeline
jpmschweitzer pushed to sprint-35/server at jpmschweitzer/settled-reach 2026-04-15 08:52:04 +02:00
5619218e31 feat(tooling): generate_atlas.py city + infrastructure pipeline and atlas DB index (#832)
d6d3b51098 docs(decisions): D-191 §8 canonical markers.json format is pixel space
b127f63dc2 feat(tooling): populate terrain_reference column for inhabited bodies (#839)
03e0d1c022 feat(simulation): brand layer schema and import pipeline (#827)
826b6fe1c7 Merge remote-tracking branch 'origin/main' into sprint-35/server
Compare 6 commits »
jpmschweitzer created branch sprint-35/server in jpmschweitzer/settled-reach 2026-04-15 08:52:03 +02:00
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#128 2026-04-15 08:42:53 +02:00
feat(ui): Sprint 35 — Atlas of the Reach (Phase 3 planetary viewer)

PR Review — sprint-35/client → main (2-reviewer consolidated)

Reviewers: Hoshe (code quality), Tyre (architecture) Verdict: CHANGES REQUESTED

Architecturally the PR is well-shaped:…