Jeroen Schweitzer jpmschweitzer
0 Followers · 0 Following
  • Joined on 2025-11-14
Repositories
13
 Projects Packages Public Activity Starred Repositories
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-21 15:07:46 +02:00
9731270c52 Merge remote-tracking branch 'origin/sprint-36/client'
50ac9041ad fix(tests): PR #134 review round 3 — seed start-state + PID log path
53fbce08fb chore(tests): hard 300s timeout + on-disk log + context-safe output
1b8e227413 refactor(ui): PR #134 review — MetaScreen/ESC chain tightening, D-192 reword
effb83a0d6 fix(ui): PR #134 review — character creation bugs + protocol default
Compare 19 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#134 2026-04-21 14:34:19 +02:00
feat(client): sprint 36 — MetaScreen pattern, character creation, bookmarks, protocol v23

Review: sprint-36/client → main (PR #134) — Round 3

Reviewers: Hoshe (code quality & tests) + Tyre (architecture).

Verdict: APPROVED

Single round-3 commit (50ac9041) cleanly…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#134 2026-04-21 14:31:19 +02:00
feat(client): sprint 36 — MetaScreen pattern, character creation, bookmarks, protocol v23

Review round 3 — all items addressed

Pushed 50ac9041 with both Hoshe items resolved.

Hoshe

jpmschweitzer pushed to sprint-36/client at jpmschweitzer/settled-reach 2026-04-21 14:30:50 +02:00
50ac9041ad fix(tests): PR #134 review round 3 — seed start-state + PID log path
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#134 2026-04-21 12:36:07 +02:00
feat(client): sprint 36 — MetaScreen pattern, character creation, bookmarks, protocol v23

Review: sprint-36/client → main (PR #134) — Round 2

Reviewers: Hoshe (code quality & tests) + Tyre (architecture).

Verdict: CHANGES REQUESTED

One test-suite regression blocks…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#134 2026-04-21 12:03:19 +02:00
feat(client): sprint 36 — MetaScreen pattern, character creation, bookmarks, protocol v23

Review round 2 — all 14 items addressed

Pushed 3 commits (effb83a0, 1b8e2274, 53fbce08) — all items from Hoshe + Tyre's review land in this push.

Hoshe — Code Quality & Tests

jpmschweitzer pushed to sprint-36/client at jpmschweitzer/settled-reach 2026-04-21 12:02:40 +02:00
53fbce08fb chore(tests): hard 300s timeout + on-disk log + context-safe output
1b8e227413 refactor(ui): PR #134 review — MetaScreen/ESC chain tightening, D-192 reword
effb83a0d6 fix(ui): PR #134 review — character creation bugs + protocol default
Compare 3 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#134 2026-04-21 11:32:23 +02:00
feat(client): sprint 36 — MetaScreen pattern, character creation, bookmarks, protocol v23

Review: sprint-36/client → main (PR #134)

Reviewers: Hoshe (code quality & tests) + Tyre (architecture).

Verdict: CHANGES REQUESTED

Four error-severity issues block merge.…

jpmschweitzer created pull request jpmschweitzer/settled-reach#134 2026-04-21 11:22:39 +02:00
feat(client): sprint 36 — MetaScreen pattern, character creation, bookmarks, protocol v23
jpmschweitzer pushed to sprint-36/client at jpmschweitzer/settled-reach 2026-04-21 10:49:47 +02:00
3a074cb3fd docs(decisions): D-192 — drop PROTOCOL_VERSION lockstep handshake
8cd5405427 fix(tests): unstick compositor cleanup; drop tautological version asserts
9d09ee548e fix(ui): loading screen blocks input + main menu polls during catalog wait
c68197f86a test(client): align test_character_creation_sprint28 to 4-tab structure
682bd821e3 feat(ui): Skills tab stub content (Workstream 8, #618)
Compare 39 commits »
jpmschweitzer pushed to main at jpmschweitzer/council 2026-04-19 20:19:26 +02:00
79be7a9aae seed example content so Bases render non-empty on first open
8876659e98 reframe CLAUDE.md around PKB-as-substrate with Council as lens
2c8df9425b add AudioPen ingest pipeline and sync architecture setup docs
2d5615b1ba add /reflect, /triage-inbox, and weekly / monthly review commands
97d71c4c49 add /ask-<member> single-agent consult commands
Compare 7 commits »
jpmschweitzer pushed to main at jpmschweitzer/council 2026-04-19 18:51:01 +02:00
d474d9edff update member memory from first Council session
2a1101d172 log first Council session on Volt NL party fit
275daf9e26 add summary.md artefact to /council output
1acf635bab normalize Obsidian base property syntax
24237d2217 add project permissions: allow git add/commit, deny destructive patterns
Compare 10 commits »
jpmschweitzer created branch main in jpmschweitzer/council 2026-04-19 18:51:01 +02:00
jpmschweitzer created repository jpmschweitzer/council 2026-04-19 18:49:49 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#132 2026-04-19 18:45:30 +02:00
feat(server): sprint 36 — bookmarks, culture, brands, D-078 retirement
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-19 18:45:28 +02:00
c3ff7040ae Merge remote-tracking branch 'origin/sprint-36/server'
13530910c9 fix(server): PR #132 review round 2 — 14 actionable comments addressed
e86e53ec06 feat(engine): retire D-078 overheard conversation system (#848)
e11a9c308a feat(engine): generate_brands pipeline — 10K minor brands from templates (#829)
bfeb7006c6 chore(content): retire overheard conversation system (#848, #842)
Compare 8 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#132 2026-04-19 18:20:03 +02:00
feat(server): sprint 36 — bookmarks, culture, brands, D-078 retirement

Review: sprint-36/server → main (round 2)

Round 1 recap: 4 blockers, 8 issues, 2 nits (14 comments). Team response: one commit (13530910) addressing all 14 items + 2 follow-up…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#132 2026-04-19 18:04:57 +02:00
feat(server): sprint 36 — bookmarks, culture, brands, D-078 retirement

Review round 2 pushed (commit 13530910). All 14 comments addressed: 4 blockers, 8 issues, 2 nits. Two follow-up tickets filed for items deferred per reviewer's acceptance: #862 (BookmarkPlugin…

jpmschweitzer pushed to sprint-36/server at jpmschweitzer/settled-reach 2026-04-19 18:04:52 +02:00
13530910c9 fix(server): PR #132 review round 2 — 14 actionable comments addressed
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#132 2026-04-19 17:35:54 +02:00
feat(server): sprint 36 — bookmarks, culture, brands, D-078 retirement

Review: sprint-36/server → main (type: code)

Pre-review checks:

  • cargo clippy clean.
  • PR test plan: 871 tests pass (3 pre-existing save_io failures unrelated). cargo deny check…