Jeroen Schweitzer jpmschweitzer
0 Followers · 0 Following
  • Joined on 2025-11-14
Repositories
13
 Projects Packages Public Activity Starred Repositories
jpmschweitzer created pull request jpmschweitzer/settled-reach#138 2026-04-22 10:30:02 +02:00
content(wiki): sprint 37 copy — D-193, v0.1 residue purge, 105 corp stubs
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#135 2026-04-22 10:29:36 +02:00
fix(client): sprint 37 sweep — test cleanup, PROTOCOL_VERSION drop (D-192)

Round-2 blockers addressed (documentation only)

  • B2 — PR body test plan: rewritten. Replaces the stale "0/0/0 runner / by inspection" language with the real make test-client result…
jpmschweitzer pushed to sprint-37/copy at jpmschweitzer/settled-reach 2026-04-22 10:29:21 +02:00
fdf8dd4842 content(wiki): author 105 brand corp stubs to three-layer depth (#861)
25eb8bd096 content(wiki): purge v0.1 Sova/Van Maanen residue (#865)
9c68613ad8 decide(content): resolve Q-095 as D-193 Lattice Commission
Compare 3 commits »
jpmschweitzer created branch sprint-37/copy in jpmschweitzer/settled-reach 2026-04-22 10:29:21 +02:00
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#137 2026-04-22 10:26:48 +02:00
refactor(server): sprint 37 sweep — D-192, D-167, D-032 cleanup + bookmark save-state + generator polish

Review: sprint-37/server → main (PR #137) — Round 2

Reviewers: Hoshe (code quality & tests) + Tyre (architecture).

Verdict: APPROVED

14 round-1 items across two reviewers → 0…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#137 2026-04-22 10:17:22 +02:00
refactor(server): sprint 37 sweep — D-192, D-167, D-032 cleanup + bookmark save-state + generator polish

Review-fix pass — commit b86bb00a

All 11 actionable items from the three reviews addressed. Summary:

Lead directive (Jeroen, 2026-04-22 09:45) — "strip stays"

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#135 2026-04-22 10:17:17 +02:00
fix(client): sprint 37 sweep — test cleanup, PROTOCOL_VERSION drop (D-192)

Review: sprint-37/client → main (PR #135) — Round 2

Reviewers: Hoshe (code quality & tests) + Tyre (architecture).

Verdict: CHANGES REQUESTED

Blockers are documentation hygiene…

jpmschweitzer pushed to sprint-37/server at jpmschweitzer/settled-reach 2026-04-22 10:10:35 +02:00
b86bb00a55 refactor(simulation): PR #137 review — audit override + regression tests + docs
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#135 2026-04-22 10:08:13 +02:00
fix(client): sprint 37 sweep — test cleanup, PROTOCOL_VERSION drop (D-192)

Review-fix pass (commit 60733738)

Thanks for the thorough review. Addressed below.

Merged origin/main

Branch was behind 9 commits (D-189 source-canonical pipeline etc.). Merged…

jpmschweitzer pushed to sprint-37/client at jpmschweitzer/settled-reach 2026-04-22 10:06:52 +02:00
60733738f2 fix(client): PR #135 review — T1/T3/H4-H7 blocking + nits
469377caa6 Merge remote-tracking branch 'origin/main' into sprint-37/client
5b68c4ce80 Merge remote-tracking branch 'origin/sprint-37/ci'
06838043fd chore(meta): update changelog for review-fix pass (PR #136)
3d9dd7d909 chore(ci): merge brand pipeline into import_economics + harden review findings
Compare 11 commits »
jpmschweitzer pushed to main at jpmschweitzer/clide 2026-04-22 10:02:15 +02:00
37108230f2 decouple Pane from PtySession so the web build compiles
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#137 2026-04-22 09:45:07 +02:00
refactor(server): sprint 37 sweep — D-192, D-167, D-032 cleanup + bookmark save-state + generator polish

Lead call on #878: strip stays, docs + tests to follow

Per memory feedback_cascade_strips_existing_code.md, the live-vs-filler determination on CharacterArchetype is a lead call. Call made:…

jpmschweitzer pushed to main at jpmschweitzer/clide 2026-04-22 09:41:13 +02:00
b9fbcd43a2 implement builtin.claude per D-041
0b451c133d record D-041: Claude panes — one primary per repo, tmux-backed
4ff5556896 implement builtin.files — workspace file tree with live watcher
e1ea52c5e4 implement builtin.terminal — general-purpose shell pane
50d9e00ea5 add shared pane widgets + Q-023 ssh-remote question
Compare 7 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#137 2026-04-22 09:29:00 +02:00
refactor(server): sprint 37 sweep — D-192, D-167, D-032 cleanup + bookmark save-state + generator polish

Review: sprint-37/server → main (PR #137) — Hoshe (code/tests)

Complementing Tyre's architecture review (already posted).

Verdict: CHANGES REQUESTED

Three error-severity items center on…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#135 2026-04-22 09:28:59 +02:00
fix(client): sprint 37 sweep — test cleanup, PROTOCOL_VERSION drop (D-192)

Review: sprint-37/client → main (PR #135)

Reviewers: Hoshe (code quality & tests) + Tyre (architecture).

Verdict: CHANGES REQUESTED

Both reviewers independently flagged merge…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#137 2026-04-22 09:23:22 +02:00
refactor(server): sprint 37 sweep — D-192, D-167, D-032 cleanup + bookmark save-state + generator polish

Tyre — architectural review (PR #137, sprint-37/server → main)

Verdict: REQUEST_CHANGES

Summary (#878 audit verdict)

The code strip (archetype trace + HeritageRoot) is mechanically…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#135 2026-04-22 09:07:48 +02:00
fix(client): sprint 37 sweep — test cleanup, PROTOCOL_VERSION drop (D-192)

Test plan update (2026-04-22)

Additional commit bc310a3c brings sprint-37 test files green.

Status after today's run:

  • make test-client — 2428/2488 passing. 60 remaining failures…
jpmschweitzer created pull request jpmschweitzer/settled-reach#137 2026-04-22 09:07:25 +02:00
refactor(server): sprint 37 sweep — D-192, D-167, D-032 cleanup + bookmark save-state + generator polish
jpmschweitzer pushed to sprint-37/client at jpmschweitzer/settled-reach 2026-04-22 09:07:03 +02:00
bc310a3ca5 fix(client): sprint 37 test-pass fixes — parse error + test hygiene
jpmschweitzer created branch sprint-37/server in jpmschweitzer/settled-reach 2026-04-22 09:06:44 +02:00