Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer deleted branch sprint-37/server from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch ci from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch client from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch sprint-31/client from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch sprint-31/server from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch sprint-32/planning from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch sprint-32/visual from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch sprint-33/ci from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch sprint-33/server from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch sprint-36/client from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch audio from jpmschweitzer/settled-reach 2026-06-17 10:32:30 +02:00
jpmschweitzer deleted branch layer1-cache-basin-direction from jpmschweitzer/settled-reach 2026-06-17 10:16:24 +02:00
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-06-17 10:16:23 +02:00
85311f716c chore(meta): T-1044/T-1047 -> done (PR #170 merged)
efa1dadfea Merge PR #170: cache TerrainAnalysis + basin_direction from D8 thalweg (T-1044, T-1047)
7c09f23b9a test(simulation): cover the Some(basin_dirs) threading + clarify on-demand default (T-1047)
7d45d78674 chore(meta): T-1044/T-1047 -> review (PR #170)
0263b68df9 feat(simulation): cache TerrainAnalysis + derive basin_direction from the D8 thalweg (T-1044, T-1047)
Compare 5 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#170 2026-06-17 10:16:22 +02:00
feat(simulation): cache TerrainAnalysis + basin_direction from D8 thalweg (T-1044, T-1047)
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#170 2026-06-17 10:12:54 +02:00
feat(simulation): cache TerrainAnalysis + basin_direction from D8 thalweg (T-1044, T-1047)

Review findings addressed — 7c09f23b9

Both Hoshe findings resolved. Gate re-run green: cargo test 1560 passed / 0 failed (+1 new), clippy --all-targets -D warnings clean, fmt…

7c09f23b9a test(simulation): cover the Some(basin_dirs) threading + clarify on-demand default (T-1047)
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#170 2026-06-17 10:05:05 +02:00
feat(simulation): cache TerrainAnalysis + basin_direction from D8 thalweg (T-1044, T-1047)

PR #170 Review — layer1-cache-basin-direction → main (code)

Reviewers: Hoshe (code quality) + Tyre (architecture), both on the branch worktree.

Verdict: CHANGES REQUESTED

jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-06-17 09:52:10 +02:00
62a60b6c50 Merge PR #169: ratify 3D asset direction (D-244) + repurpose sprite-gen, reconcile sprite-era decisions
ae7606ed83 docs(governance): address PR #169 review — reconcile sprite-era decisions + doc fixes
dae1498a6f docs(assets): ratify 3D asset direction (D-244); repurpose sprite-gen as 2D-artwork generator
e3327a0d01 chore(meta): hold asset track — T-1049/T-1050 -> backlog (needs sprite->3D re-scope)
Compare 4 commits »
jpmschweitzer deleted branch asset-direction-3d from jpmschweitzer/settled-reach 2026-06-17 09:52:10 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#169 2026-06-17 09:52:09 +02:00
docs(assets): ratify 3D asset direction (D-244) + repurpose sprite-gen as 2D-artwork generator