Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer pushed to waterline-clip at jpmschweitzer/settled-reach 2026-07-23 11:41:56 +02:00
0b14cdb21d fix(ui): T-1172 round 2 — tile wrap resolution mirrored to the painter's own direction
9914dc0d91 fix(ui): T-1172 — clip river dots/confluences/mouths against the drawn waterline
7c5dc35b38 docs(meta): D-226 two-waterline note (T-1172 — Tyre's rung-indexed-coast ruling)
48340cb6f6 chore(meta): T-1172 filed — river skeleton draws over drawn ocean (two-waterline disagreement, Jeroen's hands-on report)
Compare 4 commits »
jpmschweitzer deleted branch rivers-ladder from jpmschweitzer/settled-reach 2026-07-23 09:39:54 +02:00
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-23 09:39:49 +02:00
ee5ed4e08a chore(meta): close T-1156 wave 1 — PR #195 merged (rivers/basins/attractors on the ladder, triple review)
e8149d011e Merge remote-tracking branch 'origin/rivers-ladder'
c1cae7c9b5 test(ui): named default-visibility pins for nature overlays (PR #195 Hoshe finding)
273a1634be chore(meta): PR #195 review captures — T-1171 pole-entry wobble filed; T-1170 per-basin note; T-1156 wave-2 sibling-layer note
8a747e332c fix(ui): PR #195 review round — attractor stroke widths zoom-compensated (Tyre I1/I2/I3)
Compare 14 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#195 2026-07-23 09:35:29 +02:00
feat(simulation): T-1156 wave 1 — rivers, basins, attractors onto the Atlas zoom ladder
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#195 2026-07-23 09:33:38 +02:00
feat(simulation): T-1156 wave 1 — rivers, basins, attractors onto the Atlas zoom ladder

Review: rivers-ladder → main (type: code + visual sign-off)

Branch tip reviewed: c1cae7c9b (both fix rounds included). Reviewers: Tyre (architecture — reviewing the implementation of his…

jpmschweitzer pushed to rivers-ladder at jpmschweitzer/settled-reach 2026-07-23 09:33:32 +02:00
c1cae7c9b5 test(ui): named default-visibility pins for nature overlays (PR #195 Hoshe finding)
8a747e332c fix(ui): PR #195 review round — attractor stroke widths zoom-compensated (Tyre I1/I2/I3)
0366e8286f fix(ui): District trunk dot 2.0px/80% — Araminta's PR #195 capture objection
Compare 3 commits »
jpmschweitzer created pull request jpmschweitzer/settled-reach#195 2026-07-23 09:03:03 +02:00
feat(simulation): T-1156 wave 1 — rivers, basins, attractors onto the Atlas zoom ladder
jpmschweitzer pushed to rivers-ladder at jpmschweitzer/settled-reach 2026-07-23 09:02:54 +02:00
5a382c2e56 style(simulation): cargo fmt — assert message wrap in drainage tests
60faf667a5 fix(ui): T-1156 live rounds — zoom-compensated marker sizes; toggle-redraw regression pin
0d22e50e66 feat(ui): T-1156 — rivers/basins/attractors re-hosted onto the zoom ladder (nature overlay node)
ff98a10d42 feat(simulation): T-1156 — quantized river_class on RiverNetwork (trunk/tributary/stream)
365b044e79 docs(meta): D-226 wave-1 nature-overlay carrier note (T-1156 — Tyre's ruling)
Compare 5 commits »
jpmschweitzer created branch rivers-ladder in jpmschweitzer/settled-reach 2026-07-23 09:02:54 +02:00
jpmschweitzer deleted branch nature-octaves from jpmschweitzer/settled-reach 2026-07-22 23:43:36 +02:00
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-22 23:43:31 +02:00
825ea9749f chore(meta): close nature-first batch — T-1162/T-1161 done (PR #194 merged, triple review), T-1155 cancelled as superseded
153b4113b5 Merge remote-tracking branch 'origin/nature-octaves'
972842c320 style(simulation): cargo fmt — const assert line wrap
e5a68f4445 docs(simulation): sweep the last pre-I1 floor-framing comment (Tyre's non-blocking follow-up)
f50c93b2c8 docs(meta): PR #194 I3 — §8 step 6 erratum + D-226 filter-axis note (T-1161 two-axes supersedes COMPOSITE_SMOOTH retirement)
Compare 13 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#194 2026-07-22 23:39:10 +02:00
feat(simulation): nature-first octaves + per-rung filter policy (T-1162, T-1161)
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#194 2026-07-22 23:37:18 +02:00
feat(simulation): nature-first octaves + per-rung filter policy (T-1162, T-1161)

Review: nature-octaves → main (type: code + visual sign-off)

Branch tip reviewed: e5a68f444 (fix round included; final tip 972842c32 adds only a cargo-fmt line wrap). Reviewers: Tyre…

jpmschweitzer pushed to nature-octaves at jpmschweitzer/settled-reach 2026-07-22 23:37:04 +02:00
972842c320 style(simulation): cargo fmt — const assert line wrap
e5a68f4445 docs(simulation): sweep the last pre-I1 floor-framing comment (Tyre's non-blocking follow-up)
f50c93b2c8 docs(meta): PR #194 I3 — §8 step 6 erratum + D-226 filter-axis note (T-1161 two-axes supersedes COMPOSITE_SMOOTH retirement)
3368891976 fix(simulation): PR #194 review round — rung-floor dependency direction, golden body coverage, doc honesty
Compare 4 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#194 2026-07-22 23:34:01 +02:00
feat(simulation): nature-first octaves + per-rung filter policy (T-1162, T-1161)

PR #194 — Tyre re-review verdict: APPROVE

Re-verified all findings against the worktree at tip f50c93b2c (two commits on 336889197/f50c93b2c over what I reviewed). Every item is…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#194 2026-07-22 23:22:41 +02:00
feat(simulation): nature-first octaves + per-rung filter policy (T-1162, T-1161)

PR #194 — Architecture review (Tyre)

Verdict: REQUEST_CHANGES — the code is architecturally sound and I'd merge it after two small, cheap hardening items on the server side (one…

jpmschweitzer created pull request jpmschweitzer/settled-reach#194 2026-07-22 23:12:48 +02:00
feat(simulation): nature-first octaves + per-rung filter policy (T-1162, T-1161)
jpmschweitzer created branch nature-octaves in jpmschweitzer/settled-reach 2026-07-22 23:12:42 +02:00
jpmschweitzer pushed to nature-octaves at jpmschweitzer/settled-reach 2026-07-22 23:12:42 +02:00
a5b9c28e74 style(simulation): cargo fmt — gate bounce on T-1162 files
d33256a8ba test(simulation): regenerate believability golden — deliberate T-1162 output change
5cb63b6867 feat(simulation): T-1162 — invention octaves into the Atlas window path (coast crinkle, quarter relief, vegetation patchiness)
c9028af77e feat(ui): T-1161 — per-rung composite filter policy (Region NEAREST, District/Quarter LINEAR)
Compare 4 commits »
jpmschweitzer deleted branch ladder-cold-start from jpmschweitzer/settled-reach 2026-07-22 21:35:43 +02:00