Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#207 2026-07-25 16:08:33 +02:00
feat(ui): river source tapering + width-grammar retune — map fluency pass (T-1175)

Review: atlas-map-polish -> main (type: visual)

Reviewers: Hoshe (QA) + Araminta (art direction). Both REQUEST_CHANGES; all five findings addressed in 686021bee.

Araminta (art direction):…

jpmschweitzer pushed to atlas-map-polish at jpmschweitzer/settled-reach 2026-07-25 16:07:39 +02:00
686021bee8 fix(ui): PR #207 review round — crop-gated taper, true mitres, hybrid AA (T-1175)
jpmschweitzer created pull request jpmschweitzer/settled-reach#207 2026-07-25 15:28:26 +02:00
feat(ui): river source tapering + width-grammar retune — map fluency pass (T-1175)
jpmschweitzer pushed to atlas-map-polish at jpmschweitzer/settled-reach 2026-07-25 15:28:05 +02:00
28d2e6c80b chore(meta): update changelog
40cf89c3cb feat(ui): river source tapering + width-grammar retune — map fluency pass (T-1175)
Compare 2 commits »
jpmschweitzer created branch atlas-map-polish in jpmschweitzer/settled-reach 2026-07-25 15:28:05 +02:00
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 14:47:03 +02:00
0d8984fe53 chore(meta): pql changelog — visual-defect batch closed (T-1186/88/89/92 done, T-1193 filed)
jpmschweitzer deleted branch atlas-latitude-fix from jpmschweitzer/settled-reach 2026-07-25 14:46:35 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#206 2026-07-25 14:45:32 +02:00
fix(simulation): hemisphere-correct latitude + lake depth shading (T-1186, T-1188)
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 14:45:22 +02:00
4a9567c669 style(simulation): gate bounce — fmt wrap + clippy needless_range_loop
39f0fd8c51 fix(simulation): lake_margin_q normalizes per basin — full-range depth gradient (T-1188)
b39dd49950 docs(simulation): update step_canvas row-space doc — T-1186 is fixed (PR #206 review)
324a318b17 Merge remote-tracking branch 'origin/main' into atlas-latitude-fix
562dbc5b21 chore(meta): update changelog
Compare 7 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#206 2026-07-25 14:41:04 +02:00
fix(simulation): hemisphere-correct latitude + lake depth shading (T-1186, T-1188)

Re-eyeball round 2 — PASS (merge gate cleared)

Live run on 4a9567c66, rebuilt server, recalibrated criteria.

  • GJ1c district lake: 67 distinct color bands, radial shore→center…
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#206 2026-07-25 14:26:23 +02:00
fix(simulation): hemisphere-correct latitude + lake depth shading (T-1186, T-1188)

Eyeball round 1 → fix round 2 (T-1188 depth gradient)

The first eyeball FAILED the lake-depth shading despite every numeric gate passing: the mechanism worked end-to-end but the signal was…

jpmschweitzer pushed to atlas-latitude-fix at jpmschweitzer/settled-reach 2026-07-25 14:25:51 +02:00
4a9567c669 style(simulation): gate bounce — fmt wrap + clippy needless_range_loop
39f0fd8c51 fix(simulation): lake_margin_q normalizes per basin — full-range depth gradient (T-1188)
Compare 2 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#206 2026-07-25 13:45:53 +02:00
fix(simulation): hemisphere-correct latitude + lake depth shading (T-1186, T-1188)

Review: atlas-latitude-fix -> main (type: code)

Reviewers: Hoshe (code quality) + Tyre (architecture).

Tyre (architecture): APPROVE

No comments. Verification highlights worth the record:…

jpmschweitzer pushed to atlas-latitude-fix at jpmschweitzer/settled-reach 2026-07-25 13:45:47 +02:00
b39dd49950 docs(simulation): update step_canvas row-space doc — T-1186 is fixed (PR #206 review)
jpmschweitzer created pull request jpmschweitzer/settled-reach#206 2026-07-25 13:38:19 +02:00
fix(simulation): hemisphere-correct latitude + lake depth shading (T-1186, T-1188)
jpmschweitzer created branch atlas-latitude-fix in jpmschweitzer/settled-reach 2026-07-25 13:37:45 +02:00
jpmschweitzer pushed to atlas-latitude-fix at jpmschweitzer/settled-reach 2026-07-25 13:37:45 +02:00
324a318b17 Merge remote-tracking branch 'origin/main' into atlas-latitude-fix
jpmschweitzer deleted branch atlas-rung-presentation from jpmschweitzer/settled-reach 2026-07-25 13:29:24 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#205 2026-07-25 13:29:11 +02:00
feat(ui): cap rung extents to the body + fit/center the Global canvas (T-1189, T-1192)
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 13:29:07 +02:00
4c44786f99 docs(governance): D-255 amendment — rung-0 integer viewport-fit display ratio
374b195594 fix(ui): PR #205 review round — integer px-per-gridunit fit replaces fractional (T-1189, T-1192)
915a6790f0 chore(meta): update changelog
c1a97166c5 feat(ui): cap rung extents to the body + fit/center the Global canvas (T-1189, T-1192)
Compare 4 commits »