Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#212 2026-07-25 22:38:14 +02:00
feat(client): capture harness redesigned for the stepped Atlas (T-1157)

Fix round — all 3 findings addressed (feef7aa1c + main-side deeec94ec)

jpmschweitzer pushed to capture-harness-redesign at jpmschweitzer/settled-reach 2026-07-25 22:38:11 +02:00
feef7aa1c5 fix(client): PR #212 review fixes — true on-screen footprint_px, self-describing shot coverage
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 22:23:55 +02:00
deeec94ec9 chore(meta): pql changelog — T-1157 review transition (write-through landed main-side via FR-4 vault resolution)
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#212 2026-07-25 22:23:43 +02:00
feat(client): capture harness redesigned for the stepped Atlas (T-1157)

Review: capture-harness-redesign -> main (type: code)

Reviewers: Stig (client dev — the hoshe seat authored this branch, so the QA chair went to the engineer who owns the adjacent test seams)…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#212 2026-07-25 22:20:44 +02:00
feat(client): capture harness redesigned for the stepped Atlas (T-1157)

Verdict: APPROVE

Summary

Every claim in the commit message and PR description checks out against the real production surface: nav.push("regional", {body, system}) matches `AtlasApp._on_b…

jpmschweitzer created pull request jpmschweitzer/settled-reach#212 2026-07-25 22:16:18 +02:00
feat(client): capture harness redesigned for the stepped Atlas (T-1157)
jpmschweitzer created branch capture-harness-redesign in jpmschweitzer/settled-reach 2026-07-25 22:16:02 +02:00
jpmschweitzer pushed to capture-harness-redesign at jpmschweitzer/settled-reach 2026-07-25 22:16:02 +02:00
28a0b3e2af Merge remote-tracking branch 'origin/main' into capture-harness-redesign
a45d4a5f58 feat(client): capture harness redesigned for the stepped Atlas — (body, rung) goldens (T-1157)
Compare 2 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 21:00:51 +02:00
ae45d5e21a chore(meta): pql changelog — batch-6 prep (T-1049 re-scoped, T-1053 refined, T-1196 body pool recorded)
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 20:55:18 +02:00
7f704a08c7 chore(meta): pql changelog — visual track closed (T-1050, T-1052 done)
jpmschweitzer deleted branch visual-asset-catalog from jpmschweitzer/settled-reach 2026-07-25 20:55:07 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#211 2026-07-25 20:54:56 +02:00
docs(assets): 3D asset catalog, production path + Phase-4 style bible
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 20:54:50 +02:00
bea6c5fc4f chore(meta): update changelog
3351c595ab Merge remote-tracking branch 'origin/main' into visual-asset-catalog
2ca70d0228 docs(assets): PR #211 review fixes — ratified glazing tokens, D-257, manifest skip contract
7d5a774fa5 docs(assets): Phase-4 visual style bible in palette.md (T-1052)
f77e15d075 docs(assets): 3D-model+texture catalog, glb-gen production path, conventions (T-1050)
Compare 5 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#211 2026-07-25 20:51:26 +02:00
docs(assets): 3D asset catalog, production path + Phase-4 style bible

Fix round — all 6 findings addressed in 2ca70d022

jpmschweitzer pushed to visual-asset-catalog at jpmschweitzer/settled-reach 2026-07-25 20:51:11 +02:00
3351c595ab Merge remote-tracking branch 'origin/main' into visual-asset-catalog
08acbcb7df chore(meta): pql changelog — T-1193 first-slice incident record
9ac98542d1 fix(client): isolate viewer tests from the machine-shared atlas disk cache
2ca70d0228 docs(assets): PR #211 review fixes — ratified glazing tokens, D-257, manifest skip contract
Compare 4 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-25 20:48:49 +02:00
08acbcb7df chore(meta): pql changelog — T-1193 first-slice incident record
9ac98542d1 fix(client): isolate viewer tests from the machine-shared atlas disk cache
Compare 2 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#211 2026-07-25 20:33:16 +02:00
docs(assets): 3D asset catalog, production path + Phase-4 style bible

Review: visual-asset-catalog -> main (type: mixed docs/assets)

Reviewers: Hoshe (QA) + Tyre (architecture/governance). Both REQUEST_CHANGES.

Hoshe (QA): REQUEST_CHANGES

jpmschweitzer created pull request jpmschweitzer/settled-reach#211 2026-07-25 20:26:57 +02:00
docs(assets): 3D asset catalog, production path + Phase-4 style bible
jpmschweitzer pushed to visual-asset-catalog at jpmschweitzer/settled-reach 2026-07-25 20:26:32 +02:00
7d5a774fa5 docs(assets): Phase-4 visual style bible in palette.md (T-1052)
f77e15d075 docs(assets): 3D-model+texture catalog, glb-gen production path, conventions (T-1050)
Compare 2 commits »
jpmschweitzer created branch visual-asset-catalog in jpmschweitzer/settled-reach 2026-07-25 20:26:32 +02:00