Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-18 01:15:25 +01:00
4af2197c59 fix(ci): address PR review — filter comments, trim whitespace, warn on missing scripts
06f47747c7 chore(meta): update changelog
16cccda411 fix(schema): add missing dialogue mood and situation values
65d3b5e50c feat(ci): add content cross-reference validation (9 checks)
f06c8be313 feat(ci): add make pre-pr target and fixture staleness check
Compare 5 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#27 2026-02-18 01:14:59 +01:00
feat(ci): pre-PR verification and content cross-reference validation

Review: ci → main (type: code) — Re-review after fixes

Hoshe (Code Quality): APPROVE

All 10 previous review items are correctly addressed in 4af2197. The critical error suppression bug…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#27 2026-02-18 00:24:08 +01:00
feat(ci): pre-PR verification and content cross-reference validation

All 10 review items addressed in 4af2197:

Key fixes (4):

  1. Removed 2>/dev/null from pre-pr-fixtures — compilation failures now surface correctly
  2. Removed dead _file_type function 3.…
jpmschweitzer pushed to ci at jpmschweitzer/settled-reach 2026-02-18 00:23:30 +01:00
4af2197c59 fix(ci): address PR review — filter comments, trim whitespace, warn on missing scripts
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#27 2026-02-17 23:13:01 +01:00
feat(ci): pre-PR verification and content cross-reference validation

Review: ci → main (type: code)

Hoshe (Code Quality): APPROVE

Well-structured 2-pass validation engine with 9 meaningful cross-reference checks. Clean Makefile additions following…

jpmschweitzer created pull request jpmschweitzer/settled-reach#27 2026-02-17 22:44:45 +01:00
feat(ci): pre-PR verification and content cross-reference validation
jpmschweitzer pushed to ci at jpmschweitzer/settled-reach 2026-02-17 22:44:23 +01:00
06f47747c7 chore(meta): update changelog
16cccda411 fix(schema): add missing dialogue mood and situation values
65d3b5e50c feat(ci): add content cross-reference validation (9 checks)
f06c8be313 feat(ci): add make pre-pr target and fixture staleness check
c0f6afa082 chore(db): snapshot database after Sprint 8 PR merges
Compare 123 commits »
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-17 18:30:17 +01:00
c0f6afa082 chore(db): snapshot database after Sprint 8 PR merges
a5c30f0101 Merge remote-tracking branch 'origin/server'
7af85f126f chore(meta): update changelog for PR #26 review fixes
12d1fd505e fix(simulation): address PR #26 review comments (13 items)
a5ab8238e1 chore(meta): update changelog for Sprint 8 server
Compare 11 commits »
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-17 18:30:15 +01:00
c0f6afa082 chore(db): snapshot database after Sprint 8 PR merges
a5c30f0101 Merge remote-tracking branch 'origin/server'
2ab41a0f04 fix(client): address PR #25 review — 5 critical bugs, 4 warnings, 3 suggestions
4ccb73d364 chore(meta): update changelog
afc433be34 test(client): add boundary, P0 regression, P1 fog/entity, protocol v7 tests
Compare 8 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-17 18:29:20 +01:00
c0f6afa082 chore(db): snapshot database after Sprint 8 PR merges
jpmschweitzer closed pull request jpmschweitzer/settled-reach#26 2026-02-17 18:22:02 +01:00
feat(simulation): Sprint 8 React — dialogue pipeline, perception, determinism
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-17 18:21:59 +01:00
a5c30f0101 Merge remote-tracking branch 'origin/server'
7af85f126f chore(meta): update changelog for PR #26 review fixes
12d1fd505e fix(simulation): address PR #26 review comments (13 items)
a5ab8238e1 chore(meta): update changelog for Sprint 8 server
9c60325c2d chore(engine): update and add msgpack fixtures for protocol v8
Compare 10 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#26 2026-02-17 18:21:48 +01:00
feat(simulation): Sprint 8 React — dialogue pipeline, perception, determinism

Re-Review: server → main (type: code) — Round 2

Hoshe (Code Quality): APPROVE

All 8 original items + 5 Tyre fixes verified. 468 tests pass. No regressions.

Tyre (Architecture):…

jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-17 18:13:13 +01:00
7af85f126f chore(meta): update changelog for PR #26 review fixes
12d1fd505e fix(simulation): address PR #26 review comments (13 items)
Compare 2 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#26 2026-02-17 18:02:03 +01:00
feat(simulation): Sprint 8 React — dialogue pipeline, perception, determinism

Review: server → main (type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Solid, well-structured PR with good test density. Three warnings need addressing.

jpmschweitzer created pull request jpmschweitzer/settled-reach#26 2026-02-17 17:42:38 +01:00
feat(simulation): Sprint 8 React — dialogue pipeline, perception, determinism
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-17 17:42:22 +01:00
a5ab8238e1 chore(meta): update changelog for Sprint 8 server
9c60325c2d chore(engine): update and add msgpack fixtures for protocol v8
b1fdeabb7c test(simulation): sprint 8 test suite — pause guards, registry, boundary, determinism
35f55cfa46 feat(simulation): dialogue pipeline, ContentSlug, and walk-away KG recording
695d2ac843 feat(perception): anomaly detection and recognition monologue during delay
Compare 27 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#25 2026-02-17 17:41:04 +01:00
feat(client): Sprint 8 — dialogue pipeline, audio manager, QA tests
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-17 17:41:02 +01:00
2ab41a0f04 fix(client): address PR #25 review — 5 critical bugs, 4 warnings, 3 suggestions
4ccb73d364 chore(meta): update changelog
afc433be34 test(client): add boundary, P0 regression, P1 fog/entity, protocol v7 tests
be763908b2 refactor(client): replace fog byte magic numbers with named constants
bfc699c15d feat(ui): implement dialogue pipeline — selection, walk-away, confrontation
Compare 6 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#25 2026-02-17 17:40:51 +01:00
feat(client): Sprint 8 — dialogue pipeline, audio manager, QA tests

Re-Review: client → main (type: code) — Round 2

Hoshe (Code Quality): APPROVE

All critical and warning issues verified as fixed. Two original items confirmed as false positives (#1…