Jeroen Schweitzer jpmschweitzer
0 Followers · 0 Following
  • Joined on 2025-11-14
Repositories
13
 Projects Packages Public Activity Starred Repositories
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#36 2026-02-18 18:34:38 +01:00
feat(client): sprint 10 prove — UX polish, mouse facing, auto-checklist

Re-Review (round 2): client -> main (type: code)

Hoshe (Code Quality): APPROVE

All 4 items from previous round confirmed fixed:

  1. Rotation normalization in test_rendering.gd — all 8…
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#36 2026-02-18 18:29:21 +01:00
feat(client): sprint 10 prove — UX polish, mouse facing, auto-checklist

All 7 re-review items addressed in 503644b.

Warnings fixed (2):

  • test_rendering.gd: SW/W/NW expected rotations use Godot-normalized (-PI, PI] values
  • test_client_p3.gd: West case expects…
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-18 18:28:58 +01:00
503644beb1 fix(client): address PR #36 re-review — 7 items from Hoshe + Tyre
jpmschweitzer closed pull request jpmschweitzer/settled-reach#37 2026-02-18 18:26:36 +01:00
feat(simulation): sprint 10 prove — server
jpmschweitzer closed pull request jpmschweitzer/settled-reach#35 2026-02-18 18:26:36 +01:00
feat(ci): sprint 10 — perf baseline + validation fix
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-18 18:26:33 +01:00
c6b4017621 Merge remote-tracking branch 'origin/server'
54f43ee58c Merge remote-tracking branch 'origin/ci'
52eb8bfc81 fix(simulation): address PR #37 re-review — stale strings, test coverage, confrontation symmetry
d92a2e5f50 fix(simulation): address PR #37 review — doc corrections, race fix, marker cleanup
d0596d2763 fix(ci): address PR #35 review comments
Compare 10 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#37 2026-02-18 18:25:04 +01:00
feat(simulation): sprint 10 prove — server

Re-Review (round 3): server -> main (type: code)

Hoshe (Code Quality): APPROVE

All 3 items from previous round confirmed fixed:

  1. Doc comment now references RESET_PLATE_STABLE_IDS.1…
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-18 18:22:38 +01:00
52eb8bfc81 fix(simulation): address PR #37 re-review — stale strings, test coverage, confrontation symmetry
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#37 2026-02-18 18:18:45 +01:00
feat(simulation): sprint 10 prove — server

Re-Review: server -> main (type: code)

Hoshe (Code Quality): REQUEST_CHANGES

3/4 previous issues fully fixed. Issue #4 half-fixed: runtime filter uses the constant, but two stale "51"…

jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-18 17:50:28 +01:00
d92a2e5f50 fix(simulation): address PR #37 review — doc corrections, race fix, marker cleanup
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#36 2026-02-18 13:23:10 +01:00
feat(client): sprint 10 prove — UX polish, mouse facing, auto-checklist

Re-Review: client -> main (type: code)

Hoshe (Code Quality): REQUEST_CHANGES

7/10 previous issues cleanly fixed. Critical deactivate_insert() fix is solid. Two new warnings in facing…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#35 2026-02-18 13:23:09 +01:00
feat(ci): sprint 10 — perf baseline + validation fix

Re-Review: ci -> main (type: code)

Hoshe (Code Quality): APPROVE

All 8 previous issues confirmed fixed. Two new suggestion-level items.

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#35 2026-02-18 13:12:54 +01:00
feat(ci): sprint 10 — perf baseline + validation fix

Review comments addressed in d0596d2. All 5 Hoshe items resolved (critical TCP race documented as non-blocking contract, parser made order-independent, p95 off-by-one fixed, --compare now errors…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#36 2026-02-18 13:12:43 +01:00
feat(client): sprint 10 prove — UX polish, mouse facing, auto-checklist

All 10 review items addressed in 919ef39. Critical: deactivate_insert() now called on spoke change, cancel, and Escape. Warnings: empty-id conditions excluded from totals, content path export-safe,…

jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-18 13:12:29 +01:00
8d8da1b546 chore(meta): update changelog
d008874c14 chore(skills): add commit step to push-pr workflow
370649b3df chore(meta): update changelog
f13aafb1dd docs(meta): add asset pipeline and remote terminal proxy ideas to scratchpad
Compare 4 commits »
jpmschweitzer pushed to audio at jpmschweitzer/settled-reach 2026-02-18 13:12:06 +01:00
7282c46db0 chore(meta): update changelog
b95e82d17f chore(skills): update gen-audio skill with batch workflow and --post docs
9f7214dcd6 feat(db): add audio-batch processor and --post flag to audio-generate
Compare 3 commits »
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-18 13:10:12 +01:00
919ef39cbd fix(client): address PR #36 review — 10 items from Hoshe + Tyre
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#37 2026-02-18 13:08:42 +01:00
feat(simulation): sprint 10 prove — server

Review: server -> main (type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Well-structured PR with good test coverage. Doc/comment issues and a test gap.

jpmschweitzer pushed to ci at jpmschweitzer/settled-reach 2026-02-18 13:07:53 +01:00
d0596d2763 fix(ci): address PR #35 review comments
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#36 2026-02-18 13:03:13 +01:00
feat(client): sprint 10 prove — UX polish, mouse facing, auto-checklist

Review: client -> main (type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Substantial delivery with 48 new tests. Two issues before merge.