Files
settled-reach/client/ui
jpmschweitzerandClaude Opus 4.6 fb7cd357b8 feat(ui): location picker in Bookmark tab (Workstream 7, #680)
Adds the starting-location picker as a sub-component of the Bookmark
tab detail view, per Araminta's spec and D-128's "culture implicit in
location" constraint. Fills the space W6 reserved below the CAREER /
CAPITAL data rows.

Picker structure:
- "STARTING LOCATION" section label (DIM_TEXT, 10px, all-caps).
- ScrollContainer min_height=80 → VBoxContainer of selectable items.
- Each item: Button with child VBox carrying the location name Label
  (PRIMARY_TEXT, 12px) and an optional culture tag Label (DIM_TEXT,
  10px, mouse_filter IGNORE per D-128). Culture label is NOT rendered
  when `allowed_locations_cultures[i]` is empty — no "Unknown"
  placeholder, the row just shrinks.

Behavior:
- Clicking a bookmark card auto-selects its default_location in the
  picker (handled via _selected_location_id + _update_location_selection).
- Clicking a location item updates _selected_location_id and re-gates
  the Start button (already checked in W6).
- Switching bookmarks rebuilds the picker list for the new
  allowed_locations; prior selection cleared.
- Parallel-array length mismatch defended: reads
  `cultures[i] if i < cultures.size() else ""` so a short cultures
  array won't crash rendering.

D-128 compliance:
- No culture dropdown or filter anywhere.
- Culture tag Label is strictly display: MOUSE_FILTER_IGNORE, no
  signal handlers.
- CharacterProfile carries only start_location_id; no culture_id.

Other: removes W6's placeholder "Starting Location: X" ImplantDataRow
since the picker supersedes it; separator before the picker preserved.

Verification:
- gdlint clean
- Headless parse + scanner check (widened per hardened pr-push skill):
  no new errors. Pre-existing autoload class_name noise filtered per
  CLAUDE.md.
- test_character_creation_sprint28 88/88, test_protocol 62/62,
  test_implant_* all green, test_client_p3 24/24,
  test_ui_framework_sprint15 54/54.

Workstream 8 (Skills tab stub content) lands next — #618 closes then.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-20 20:28:02 +02:00
..