jpmschweitzerandClaude Opus 4.8
f771c9ce4e
Stack review (Hoshe + Tyre) of T-1083+T-1082+T-1080. Every finding fixed or disposed: - believability.rs sample_indices: replace the rejection-sampling loop (could stall when n ≈ take) with deterministic partial Fisher-Yates — O(n), guaranteed termination, distinct, sorted (Hoshe+Tyre). - believability.rs drainage proxy: exclude water-body districts (all elev 0, no banks) and require both wet + dry voxels — they were passing vacuously and inflating the metric (Hoshe). - believability.rs read_cities: log skipped malformed rows instead of dropping silently (Hoshe). - voxel.rs: add the 3 WaterBody zones to all_families_no_panic_at_extreme_positions + fix the "7 families" comment (Hoshe). - climate_constants.toml: bold warning that [moisture_gradient] is not loaded until T-1032 — tune ClimateConstants::default() (Tyre). - Q-123: record the per-zone "water renders wet" threshold + the land-relative vegetation-present denominator as calibration items (Tyre + the open 7th criterion). - T-1083 ticket: note the sampling-fix attribution (landed in the T-1082 commit). Believability golden regenerated (sampler + drainage fixes moved the metrics). clippy --all-targets -D warnings clean; 1580 lib tests + harness pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
81 lines
1.6 KiB
JSON
81 lines
1.6 KiB
JSON
[
|
|
{
|
|
"body_id": "GJ338Bd",
|
|
"world_seed": 13200299156134074780,
|
|
"district_count": 2048,
|
|
"voxel_sampled_districts": 64,
|
|
"contrast": {
|
|
"moisture_q": {
|
|
"min": 32,
|
|
"max": 80,
|
|
"distinct": 49
|
|
},
|
|
"elev_q": {
|
|
"min": 0,
|
|
"max": 98,
|
|
"distinct": 99
|
|
},
|
|
"slope_q": {
|
|
"min": 0,
|
|
"max": 13,
|
|
"distinct": 14
|
|
},
|
|
"ocean_fraction_q": {
|
|
"min": 0,
|
|
"max": 100,
|
|
"distinct": 65
|
|
},
|
|
"morphology_zones": 9,
|
|
"vegetation_classes": 3,
|
|
"terrain_materials": 4
|
|
},
|
|
"coherence": {
|
|
"water_districts": 49,
|
|
"water_districts_wet": 44,
|
|
"drainage_samples": 0,
|
|
"drainage_monotonic": 0,
|
|
"vegetation_samples": 64,
|
|
"vegetated_districts": 8
|
|
}
|
|
},
|
|
{
|
|
"body_id": "GJ244Ad",
|
|
"world_seed": 13200299156134074780,
|
|
"district_count": 2048,
|
|
"voxel_sampled_districts": 64,
|
|
"contrast": {
|
|
"moisture_q": {
|
|
"min": 0,
|
|
"max": 20,
|
|
"distinct": 21
|
|
},
|
|
"elev_q": {
|
|
"min": 0,
|
|
"max": 99,
|
|
"distinct": 100
|
|
},
|
|
"slope_q": {
|
|
"min": 0,
|
|
"max": 6,
|
|
"distinct": 7
|
|
},
|
|
"ocean_fraction_q": {
|
|
"min": 0,
|
|
"max": 100,
|
|
"distinct": 65
|
|
},
|
|
"morphology_zones": 9,
|
|
"vegetation_classes": 1,
|
|
"terrain_materials": 4
|
|
},
|
|
"coherence": {
|
|
"water_districts": 25,
|
|
"water_districts_wet": 22,
|
|
"drainage_samples": 0,
|
|
"drainage_monotonic": 0,
|
|
"vegetation_samples": 64,
|
|
"vegetated_districts": 0
|
|
}
|
|
}
|
|
]
|