jpmschweitzerandClaude Opus 4.6
6d6b59c17b
Critical: - Protocol test assertions updated v6→v7 (test_protocol_v6.gd) - Dialogue signal connections wired (option_selected→DialogueResponse, dialogue_dismissed→DialogueEnd sent to server via SimBridge) - Consume-once race fixed: _consume_dialogue() checks is_dialogue_active() before re-showing; dialogue_id tracking prevents re-trigger during fade - Dialogue box responsive: _update_layout() clamps width to MAX_WIDTH_PX (832px) or 65% viewport, height to 20% viewport (MAX_HEIGHT_RATIO) - Auto-pause added: SimBridge.send_input(PAUSE) on dialogue open/close Warnings: - Test coverage: 16 new tests in test_protocol_v7.gd (pending_recognitions decode, current_dialogue, GameState, SimBridge mock data, insert colors) - queue_redraw() optimization: early return when no entities and no pings - Fixed 200px height → responsive 20% viewport via _update_layout() Suggestions: - WASD detection refactored to _WALK_AWAY_ACTIONS array loop - Button colors reference Constants.INSERT_COLOR_TEXT/HOVER/ACTIVE - Named constants: COLOR_TRANSITION_START, SILHOUETTE_APPEAR_THRESHOLD, SILHOUETTE_SIZE with explanatory comments - Bounds check: MAX_PENDING_RECOGNITIONS=64 with truncation warning - Mock dialogue sustained across ticks (not 1-tick flash) - COLOR_PING coupling with cursor documented as intentional - Consume helpers extracted: _consume_monologue(), _consume_dialogue() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
83 lines
4.3 KiB
GDScript
83 lines
4.3 KiB
GDScript
class_name Constants
|
|
|
|
# Shared constants used across rendering, game state, and protocol layers.
|
|
|
|
## Tile size in pixels — all renderers and coordinate conversions use this.
|
|
const TILE_SIZE: int = 32
|
|
|
|
# D-049 Z-level rendering pipeline — three-scope architecture.
|
|
# Full spec: docs/architecture/z-layer-gap-analysis.md
|
|
#
|
|
# WORLD SCOPE (z:-200 to z:900, inside FogGroup CanvasGroup)
|
|
# All world content composited into one texture, then fog drawn over it.
|
|
# Y-sort contract: all children of YSortGroup MUST use z_index = 0.
|
|
# z_index is PRIMARY sort, y-position is SECONDARY (Godot #62715).
|
|
const Z_FLOOR: int = 0 # Floor tiles — ground plane
|
|
const Z_FLOOR_OBJECTS: int = 10 # Floor objects — cosmetic, ground shadows
|
|
# z:20-99 reserved: liquid surface (z:110), surface effects
|
|
const Z_YSORT: int = 100 # YSortGroup — furniture + entities + walls, all z:0 relative
|
|
# z:110 reserved: liquid surface occlusion (alpha by depth)
|
|
# z:150-199 reserved: ground VFX (smoke origins, gas pools, sparks)
|
|
const Z_AIRBORNE: int = 200 # Projectiles, low-flying objects (scale ~1.0)
|
|
# z:250-299 reserved: mid-air VFX (rising smoke, floating particles)
|
|
const Z_OVERHEAD: int = 300 # Ceiling edges, upper structure, semi-transparent
|
|
# z:325-349 reserved: ceiling VFX (smoke through ceiling)
|
|
const Z_HIGH_AIRBORNE: int = 350 # Above-ceiling flying (scale 1.03-1.30, alpha fades)
|
|
const Z_UPPER_CONTENT: int = 400 # Upper-floor entities (rare with fixed camera)
|
|
# z:500-899 reserved: edge cases
|
|
const Z_FOG: int = 900 # FogOverlay — OUTSIDE FogGroup, fog shader
|
|
const Z_FOG_ENTITIES: int = 950 # FogEntities — cognitive delay blobs/pings (D-059/D-060)
|
|
# Lower floors: z:-100 per floor (floor-1: z:-100 to z:-1, floor-2: z:-200 to z:-101)
|
|
# z:-75 to z:-51 reserved: lower floor VFX
|
|
#
|
|
# INSERT SCOPE (CanvasLayer 10)
|
|
# Bloom-rendered, not affected by fog or camera transform.
|
|
const CANVAS_INSERT: int = 10 # CanvasLayer number for InsertOverlay
|
|
#
|
|
# UI SCOPE (CanvasLayer 20)
|
|
# HUD, monologue, cursor — always visible.
|
|
const CANVAS_UI: int = 20 # CanvasLayer number for UILayer
|
|
#
|
|
# MODAL SCOPE (CanvasLayer 30)
|
|
# Full-screen overlays: pause, inventory modal, death screen.
|
|
const CANVAS_MODAL: int = 30 # CanvasLayer number for ModalLayer
|
|
#
|
|
# Rendering ceiling: 10 floors (25m) above current floor.
|
|
# Above this: no sprites, ground shadows + environmental effects only.
|
|
const RENDER_CEILING_FLOORS: int = 10
|
|
# Visible floor window (looking down): current - 2 floors (detailed + parallax).
|
|
const VISIBLE_FLOOR_DEPTH: int = 2
|
|
|
|
# D-033: Entity relationship color palette
|
|
# Color represents the player's RELATIONSHIP to the entity, not an objective property.
|
|
# Phase 1: default colors mapped by entity kind (Player/Npc/Object/Terrain).
|
|
# Phase 2 (#361): colors derived from RelationshipState via the knowledge graph.
|
|
const ENTITY_COLOR_UNKNOWN: Color = Color("#4a9ebb") # Unknown/Neutral — cool teal
|
|
const ENTITY_COLOR_FRIENDLY: Color = Color("#6bc9a6") # Known/Friendly — soft green
|
|
const ENTITY_COLOR_POI: Color = Color("#e8c547") # Person of Interest — warm amber
|
|
const ENTITY_COLOR_HOSTILE: Color = Color("#d45d5d") # Hostile/Dangerous — muted red
|
|
const ENTITY_COLOR_OBJECT: Color = Color("#8b8ba0") # Static objects — muted grey
|
|
const ENTITY_COLOR_PLAYER: Color = Color("#e0e8ff") # Player character (detective)
|
|
|
|
# D-033 color lookup by entity kind (Phase 1: defaults, Phase 2 #361: relationship-based)
|
|
static func color_for_entity_kind(entity_data: Dictionary) -> Color:
|
|
var kind_variant: String = entity_data.get("kind", {}).get("variant", "")
|
|
match kind_variant:
|
|
"Player": return ENTITY_COLOR_PLAYER
|
|
"Npc": return ENTITY_COLOR_UNKNOWN
|
|
"Object", "Terrain": return ENTITY_COLOR_OBJECT
|
|
_: return ENTITY_COLOR_OBJECT
|
|
|
|
# D-048/D-056: Insert-styled UI color palette
|
|
# Used by dialogue box, interaction list, radial menu, and other diegetic insert UI.
|
|
const INSERT_COLOR_TEXT: Color = Color("#c8d0e0") # Default insert text — white-blue
|
|
const INSERT_COLOR_HOVER: Color = Color("#e8c547") # Hover/highlight — amber POI
|
|
const INSERT_COLOR_ACTIVE: Color = Color("#6bc9a6") # Active/pressed — friendly green
|
|
|
|
# D-015: Peripheral vision dimming
|
|
const PERIPHERAL_ALPHA: float = 0.5
|
|
|
|
# Facing direction indicator
|
|
const FACING_INDICATOR_SIZE: float = 6.0
|
|
const FACING_INDICATOR_OFFSET: float = 14.0
|