jpmschweitzerandClaude Opus 5.5
668772075c
The 30-file tree moves under atlas as its third rung (D-243), ten verbs fronting it. Each verb restates its module's options so `--help` describes something; tooling/test_planet_router.py hands every declared option to the module's own argparse and fails on drift, and now runs in make test-tooling. The 2026-09-02 half of this move had converted the top-level imports and the repo roots. Finishing it found what the half-move left: - Lazy in-function imports, and all of sol_data/, still named siblings bare. They resolved only through sys.path.insert hacks, so under reach the first globe render in generate, batch or sol-import would have raised ModuleNotFoundError. Qualified; the hacks are gone. - 247 print() calls and a stdout progress writer that fired once per 8 KB block. Report verbs (audit, quality) write through console.out, progress through console.event, and download progress is throttled to 10% steps so a job log is not tens of thousands of lines. - Every error exit raises ReachError with a fix. Two checks that could not fail: - batch --verify-determinism printed a warning and exited 0 on a mismatch. - import-provinces exited 0 with errors > 0. Both now raise. The 271-body bake is only safe to re-run because the first one holds. sol-import --body is action="append" in the module but the router took one value, so --body GJ0d --body GJ0e kept one. Now repeatable, and _flags repeats list options. test_conformance walked one level, so a nested group was reported as a verb missing @command and its ten verbs were never checked. It recurses now; proven by stripping @command from `planet quality` and watching it fail. Stray PNGs from the 2026-09-03 runaway router-test run are parked in .cache/t1288-stray-pngs/, not committed. Their reliefmaps differ from HEAD while the heightmap regenerated byte-identical — filed as T-1291. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
27 lines
966 B
Python
27 lines
966 B
Python
"""
|
|
Gas giant body definition helpers for Jupiter, Saturn, Uranus, Neptune.
|
|
|
|
Gas giants have no solid surface — the existing planet_renderer._render_gas_giant()
|
|
handles band patterns procedurally. This module only provides configuration
|
|
validation and body_def enhancement. No terrain dict is produced.
|
|
|
|
The actual overrides are in sol_overrides.json and applied by the body
|
|
definition parser. This module exists for future enhancement (ring tuning,
|
|
storm placement, etc).
|
|
"""
|
|
from tooling.core import console
|
|
|
|
|
|
def validate_gas_giant_def(body_def: dict) -> bool:
|
|
"""Check that a gas giant body_def has required fields for rendering."""
|
|
pc = body_def.get("planet_class", "")
|
|
if "gas_giant" not in pc and pc not in ("gas_giant",):
|
|
return False
|
|
|
|
gg = body_def.get("gas_giant", {})
|
|
if not gg.get("band_palette"):
|
|
console.event(f"{body_def['id']} missing gas_giant.band_palette", level="warn")
|
|
return False
|
|
|
|
return True
|