jpmschweitzerandClaude Opus 5
49fa6ada95
Every non-zero exit names the command that would fix it, and still exits non-zero. Both halves matter; the second is the one that gets lost, because a tool that explains itself beautifully and exits 0 looks MORE correct while having silently disabled its own gate. core/errors.py holds ReachError(message, fix=) and @handle_errors. core/logging.py holds @logged, emitting through console rather than a second sink — one output path, so there is nothing to drift. core/command.py composes them, and the order is load-bearing: handle_errors wraps logged, so the logger sees the original exception. Inverted, every failure would be recorded as "SystemExit" and the log would say nothing about what went wrong while looking like it worked. core/ raises SystemExit, not typer.Exit. A service must be callable from a test, another service, or a future second front end, and an exception type that only makes sense inside a CLI leaks the transport into every layer. The check router is retrofitted off its hand-rolled verdict-and-exit pattern — exactly the boilerplate this removes — and test_check_parity.py passes unchanged across the retrofit. That test predates the decorators and pins exit codes against the old script, so it is independent evidence, not a test tuned to match new behaviour. Unknown domains and unknown verbs now enumerate what exists instead of only saying no. That needed a shared group class, which collided with "no typer outside main.py and router.py" — resolved by sharpening the invariant rather than breaking it, since its purpose is that a SERVICE never knows it was called from a CLI. Transport now lives in main.py, router.py and core/cli.py; never in service.py, schemas.py or helpers.py. The upside is that cli.domain() carries the settings that were previously per-router decisions, including the load-bearing rich_markup_mode=None that one forgetful domain could have undone. test_conformance.py makes five invariants executable, AST-based rather than grep. Scoped to the package, not the 123 legacy scripts — and deliberately so: as T-1250 moves each script into domains/, it lands inside the scope and the rules start applying automatically, so the test's reach grows with the migration. Proven to fail before being trusted: removing @command and removing a fix= each produced a failure naming the file, the line and the reason. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
48 lines
1.5 KiB
Python
48 lines
1.5 KiB
Python
"""Session-level interaction state. No domain, so it lives in core (D-263).
|
|
|
|
One question, asked in one place: **may this invocation prompt?**
|
|
|
|
The answer is not just a flag, because the flag alone is not safe. A prompt with
|
|
no TTY does not wait for an answer — it *crashes*, which is the recorded `tea`
|
|
failure in this repo (interactive prompts die in Claude Code, no terminal). So
|
|
`can_prompt()` requires both an interactive stream and the absence of
|
|
`--no-input`. Hooks and agents pass `--no-input` explicitly, and would be
|
|
protected by the TTY check even if they forgot.
|
|
|
|
Nothing prompts today. This exists so that the first thing that wants to has an
|
|
obvious correct answer available, rather than inventing its own `isatty` check
|
|
that gets it half right.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
|
|
_no_input = False
|
|
|
|
|
|
def set_no_input(value: bool) -> None:
|
|
"""Record the `--no-input` flag for this invocation."""
|
|
global _no_input
|
|
_no_input = value
|
|
|
|
|
|
def no_input() -> bool:
|
|
"""True when the caller has forbidden prompting."""
|
|
return _no_input
|
|
|
|
|
|
def can_prompt() -> bool:
|
|
"""True only when prompting is both permitted AND possible.
|
|
|
|
Check this, never `isatty` alone and never the flag alone — the two guard
|
|
different failures. The flag is a caller's instruction; the TTY check is
|
|
what stops a prompt from crashing a hook that forgot to pass it.
|
|
"""
|
|
if _no_input:
|
|
return False
|
|
try:
|
|
return sys.stdin.isatty() and sys.stderr.isatty()
|
|
except (AttributeError, ValueError):
|
|
return False
|