
jpmschweitzerandClaude Opus 4.8
7597e3165e
fix(simulation): address PR #171 review — all findings processed (T-987)
Every review finding fixed (no non-blocking parking lot):
- shell.rs: debug_assert the D-110 floor-range i8 invariant (H1); clarify the
ground_offset fallback comment (T1) and the roof_z None-case (T3); clarify the
sub-chunk clip test comment (T4); add a test for the elevated/no-ground-floor
fallback (H2).
- scale.rs: add CHUNKS_PER_BLOCK (= BLOCK_M/CHUNK_M) + compile-time asserts; used
by shell.rs fill_chunk's sub_chunk bounds assert (T5).
- gen_queue.rs: document why FillChunk's Vec<BuildingPropertyTag> needs no Box
(large_enum_variant non-issue) (T2).
clippy --all-targets -D warnings clean; 1572 lib tests pass (+1).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-28 10:24:30 +02:00
..
2026-04-22 08:55:48 +02:00
2026-06-12 20:13:41 +02:00
2026-06-17 09:46:42 +02:00
2026-04-15 23:11:14 +02:00
2026-06-28 10:24:30 +02:00
2026-06-17 09:46:42 +02:00
2026-03-17 10:33:15 +01:00
2026-04-19 13:12:23 +02:00
2026-06-12 16:22:28 +02:00
2026-06-12 16:22:28 +02:00
2026-04-19 13:12:23 +02:00