jpmschweitzerandClaude Opus 4.6 12d1fd505e fix(simulation): address PR #26 review comments (13 items) ...

Warnings fixed:
- Add WalkAway to all_player_action_variants_roundtrip test
- Warn and skip on unresolvable speaker_entity_id (was silent 0)
- Change MonologueState.shown_ids from Vec to HashSet (O(1) lookup)
- Add cross-plugin ordering: trigger_recognition_monologue after
  detect_anomalies (latent determinism bug)
- Add TODO for unreachable Secret trust tier

Suggestions addressed:
- Server-side range check for Talk verb in handle_talk (CLOSE_RANGE)
- Emit IncompleteInteraction before overwriting ActiveDialogue
- Add different_seed_produces_different_replay determinism test
- Replace panic with assert for unknown fixture naming convention
- Fix duplicate "Observe" label: ExamineNpc now uses "Examine NPC"
- Change DialogueCooldownTracker.used from Vec to BTreeMap (D-041)
- Add .after(process_talk_interaction) to process_walk_away ordering
- Collapse dead conditional in main.rs (both branches identical)

468 tests pass, 0 failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2026-02-17 18:12:45 +01:00

..

src

fix(simulation): address PR #26 review comments (13 items)

2026-02-17 18:12:45 +01:00

tests

fix(simulation): address PR #26 review comments (13 items)

2026-02-17 18:12:45 +01:00

Cargo.lock

feat(simulation): implement content loader Phase 2 (#408)

2026-02-13 01:19:29 +01:00

Cargo.toml

feat(simulation): implement content loader Phase 2 (#408)

2026-02-13 01:19:29 +01:00