jpmschweitzer and Claude Opus 4.6
d92a2e5f50
fix(simulation): address PR #37 review — doc corrections, race fix, marker cleanup
...
Hoshe review (4 items):
- types.rs: doc comment "Current: 6" → "Current: 9"
- dialogue.rs: walk-away doc duplicated numbering (items 4-5 were 2-3)
- test_world/mod.rs: comment "Reset plates at 49-51" → "49-55"
- content_scaling.rs: magic number 51 → constants::RESET_PLATE_STABLE_IDS.1
Tyre review (3 items):
- knowledge/types.rs: guard comments on decrement() floor at Hostile
- input.rs: TeleportToHub now clears ConfrontationDelivered marker
- content_scaling.rs: same magic number fix (covered above)
Additional:
- content_runtime.rs: barrier-based shutdown handshake fixes TCP RST
race condition under parallel test execution
- dialogue_room.rs: clippy type_complexity allow on NPCS tuple array
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-18 17:50:22 +01:00
jpmschweitzer and Claude Opus 4.6
273d29f26f
feat(simulation): sprint 10 — hub teleport, confrontation response, walk-away phase 2, gauntlet rooms 4-7, blocked_entities debug field
...
#491 : PlayerAction::TeleportToHub — moves player to hub spawn, clears
dialogue/monologue/interaction buffer, Gauntlet-only with log warning.
#520 : ConfrontationDelivered event — Tier 2 animation shift, relationship
state decrement (D-033), monologue spike emission.
#519 : Walk-away Phase 2 — NPC animation shift + routine deviation on
dialogue exit (D-064).
#498 : Four new Gauntlet rooms — Interaction Gallery, Fog Theater, Crowd
Plaza, Dialogue Room with constants and wiring.
#514 : blocked_entities Vec<u64> on ObserverSnapshot, protocol v9.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-18 12:58:14 +01:00
jpmschweitzer and Claude Opus 4.6
d5a1f6dadb
refactor(simulation): apply rustfmt formatting
...
Formatting-only changes across server source and test files.
No logic changes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-18 01:39:44 +01:00
jpmschweitzer and Claude Opus 4.6
12d1fd505e
fix(simulation): address PR #26 review comments (13 items)
...
Warnings fixed:
- Add WalkAway to all_player_action_variants_roundtrip test
- Warn and skip on unresolvable speaker_entity_id (was silent 0)
- Change MonologueState.shown_ids from Vec to HashSet (O(1) lookup)
- Add cross-plugin ordering: trigger_recognition_monologue after
detect_anomalies (latent determinism bug)
- Add TODO for unreachable Secret trust tier
Suggestions addressed:
- Server-side range check for Talk verb in handle_talk (CLOSE_RANGE)
- Emit IncompleteInteraction before overwriting ActiveDialogue
- Add different_seed_produces_different_replay determinism test
- Replace panic with assert for unknown fixture naming convention
- Fix duplicate "Observe" label: ExamineNpc now uses "Examine NPC"
- Change DialogueCooldownTracker.used from Vec to BTreeMap (D-041)
- Add .after(process_talk_interaction) to process_walk_away ordering
- Collapse dead conditional in main.rs (both branches identical)
468 tests pass, 0 failures.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-17 18:12:45 +01:00
jpmschweitzer and Claude Opus 4.6
35f55cfa46
feat(simulation): dialogue pipeline, ContentSlug, and walk-away KG recording
...
Implement full dialogue selection pipeline (D-028): 4-layer filtering
engine with access tier, situation derivation, trust tier, and weighted
topic+mood scoring via SimRng. Add ContentSlug component for stable
content identity across save/load. Add walk-away KG recording with
IncompleteInteraction events per D-064 three-phase consequences. Bump
protocol to v8 with DialogueResponseEvent. Fixes #305 , #427 , #452 .
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-17 17:41:23 +01:00
jpmschweitzerandClaude Opus 4.6