  jpmschweitzerandClaude Opus 4.6
|
52eb8bfc81
|
fix(simulation): address PR #37 re-review — stale strings, test coverage, confrontation symmetry
Hoshe re-review (3 items):
- content_scaling.rs:185: doc "StableId 0-51" → references constant
- content_scaling.rs:256: assertion message "id<=51" → "id <= max_baseline_id"
- input.rs: teleport test now asserts WalkAwayRequest + ConfrontationDelivered
are cleared (was only checking TalkRequest + ActiveDialogue)
Tyre re-review (2 items):
- input.rs: same teleport test coverage (overlaps Hoshe #3)
- dialogue.rs: process_confrontation_response now inserts RoutineDeviation
with DeviationTrigger::Confrontation — symmetric with walk-away path.
Test updated to verify deviation is recorded.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2026-02-18 18:22:32 +01:00 |
|
|
jpmschweitzerandClaude Opus 4.6
|
d92a2e5f50
|
fix(simulation): address PR #37 review — doc corrections, race fix, marker cleanup
Hoshe review (4 items):
- types.rs: doc comment "Current: 6" → "Current: 9"
- dialogue.rs: walk-away doc duplicated numbering (items 4-5 were 2-3)
- test_world/mod.rs: comment "Reset plates at 49-51" → "49-55"
- content_scaling.rs: magic number 51 → constants::RESET_PLATE_STABLE_IDS.1
Tyre review (3 items):
- knowledge/types.rs: guard comments on decrement() floor at Hostile
- input.rs: TeleportToHub now clears ConfrontationDelivered marker
- content_scaling.rs: same magic number fix (covered above)
Additional:
- content_runtime.rs: barrier-based shutdown handshake fixes TCP RST
race condition under parallel test execution
- dialogue_room.rs: clippy type_complexity allow on NPCS tuple array
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2026-02-18 17:50:22 +01:00 |
|
|
jpmschweitzerandClaude Opus 4.6
|
6c62e2228f
|
test(simulation): sprint 10 — replay loading, content scaling, serialization v9, observer tests
#483: Replay loading in test-client — JSONL file loading, tick-scheduled
PlayerInput sending, 13 unit tests, 3 sample replay files.
#500: Content scaling test — baseline + extra NPC comparative, tick budget
assertion (D-026), determinism check across content packs.
#514: Serialization tests for protocol v9 — blocked_entities roundtrip,
backward compat (v5→v9, v8→v9), regenerated msgpack fixtures.
Observer perception tests for confrontation + walk-away mechanics.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2026-02-18 12:58:27 +01:00 |
|