2 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude Opus 4.6	ea7bcfabfb	fix(ui): PR #131 review round 3 — nits sweep ... Seven nit-level fixes from PR review: - Remove dead signal insert_deactivated from ImplantApp; the hook method on_insert_deactivated() is the actual contract. - Rewrite _on_atlas_economics_link comment in main.gd to reflect the actual flow (AtlasApp closes as a consequence of HudGroups single- active-app, not before emitting anything). - Document the "pop never empties below default" invariant on ImplantNavStack.pop() with a pointer to reset_to_default. - Add _mutating re-entrancy guard on ImplantNavStack mutation methods. push_error + early return if called during a screen_changed emission. - main.gd registry loop now uses typed ImplantAppManifest property access (manifest.app_path, manifest.default_key) instead of dictionary-style .get() calls. Empty app_path triggers push_warning. - Document the economics [/] hotkey exception in main.gd and reference the planned handle_global_key lifecycle hook. Arch doc Follow-up section gains a bullet for the new hook. - Comment the independent-version-read rationale above client_ver and proto_ver in loading_screen.gd. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-19 14:47:05 +02:00
jpmschweitzerandClaude Sonnet 4.6	df29d26d1e	feat(ui): introduce ImplantApp pattern — base class, registry, atlas + economics refactor (#844, #824, #836) ... Establishes the ImplantApp faux-mobile-OS architecture (D-191): Foundation: - ImplantAppManifest (Resource): @export vars for app_path, scene_path, default_key, default_mode, preserves_state - ImplantNavStack (Node): push/pop/replace/reset_to_default, synchronous screen_changed signal - ImplantApp (Control base class): absorbs HudGroups boilerplate; on_install/on_open/on_close/on_insert_deactivated lifecycle hooks - ImplantRegistry (autoload): lazy-scans res://ui/implant/apps/*/app.tres; avoids autoload parse-order trap Atlas app (replaces atlas_panel + atlas_reach_map + atlas_system_map + atlas_planet_map + root viewer files): - apps/atlas/app.tres — manifest (implant/map, FULLSCREEN, key=M) - apps/atlas/atlas_app.gd — coordinator; 4-screen nav via ImplantNavStack - apps/atlas/screens/{reach,system,planet,regional}_screen.gd — enter/leave interface - apps/atlas/{atlas_viewer,atlas_marker_overlay,atlas_overlay_bar}.gd — moved from root Economics app (replaces economics_panel): - apps/economics/app.tres — manifest (implant/economics, INSERT, key=N) - apps/economics/economics_app.gd — thin shell delegating to OverviewScreen - apps/economics/screens/overview_screen.gd — full panel logic, enter/leave interface Wiring: - project.godot: add ImplantRegistry autoload after HudGroups - main.gd: registry-driven key toggle loop; rename atlas_panel→atlas_app, economics_panel→economics_app - hud.tscn: swap to new scene paths; remove legacy StarMap node - snapshot_consumers.gd: on_insert_deactivated() uniformly; rename vars - hud_groups.gd: remove stale starchart compat comment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-19 13:16:56 +02:00