  jpmschweitzerandClaude Opus 4.6
|
d92a2e5f50
|
fix(simulation): address PR #37 review — doc corrections, race fix, marker cleanup
Hoshe review (4 items):
- types.rs: doc comment "Current: 6" → "Current: 9"
- dialogue.rs: walk-away doc duplicated numbering (items 4-5 were 2-3)
- test_world/mod.rs: comment "Reset plates at 49-51" → "49-55"
- content_scaling.rs: magic number 51 → constants::RESET_PLATE_STABLE_IDS.1
Tyre review (3 items):
- knowledge/types.rs: guard comments on decrement() floor at Hostile
- input.rs: TeleportToHub now clears ConfrontationDelivered marker
- content_scaling.rs: same magic number fix (covered above)
Additional:
- content_runtime.rs: barrier-based shutdown handshake fixes TCP RST
race condition under parallel test execution
- dialogue_room.rs: clippy type_complexity allow on NPCS tuple array
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2026-02-18 17:50:22 +01:00 |
|
|
jpmschweitzerandClaude Opus 4.6
|
09eb6d7582
|
refactor(simulation): address PR #32 review — 14 items from Hoshe + Tyre
Hoshe (code quality):
- Remove dead RoomMember component from reset.rs
- Remove execute_reset (dual API trap); plan_reset is sole production path
- .unwrap() → .expect() on reset_plate in setup_gauntlet boot path
- Add 10s read timeout to TCP runtime test (prevents hangs)
- Register player in EntityRegistry in runtime boot test
- Document room_at z-range and corridor overlap assumptions
- Derive entity count from EXPECTED_ENTITY_COUNT constant (was hardcoded 24)
- Add reset plate (49-51) verification to stable_id_ranges_match_spec
- Add debounce exact boundary test (tick 9 rejected, tick 10 accepted)
Tyre (architecture):
- Gate test_world rooms/constants/setup behind "gauntlet" feature (default-on);
reset module stays always-compiled (production dependency via input system)
- Document setup_gauntlet scheduler bypass for future tracking
- Extract runtime TCP test to content_runtime.rs (separate failure modes)
507 tests passing.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2026-02-18 09:45:17 +01:00 |
|