2 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude Opus 4.8	7597e3165e	fix(simulation): address PR #171 review — all findings processed (T-987) ... Every review finding fixed (no non-blocking parking lot): - shell.rs: debug_assert the D-110 floor-range i8 invariant (H1); clarify the ground_offset fallback comment (T1) and the roof_z None-case (T3); clarify the sub-chunk clip test comment (T4); add a test for the elevated/no-ground-floor fallback (H2). - scale.rs: add CHUNKS_PER_BLOCK (= BLOCK_M/CHUNK_M) + compile-time asserts; used by shell.rs fill_chunk's sub_chunk bounds assert (T5). - gen_queue.rs: document why FillChunk's Vec<BuildingPropertyTag> needs no Box (large_enum_variant non-issue) (T2). clippy --all-targets -D warnings clean; 1572 lib tests pass (+1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-28 10:24:30 +02:00
jpmschweitzerandClaude Opus 4.8	5f85dc55d5	feat(simulation): FillChunk shell derivation — Void/Wall/FloorSlab/Roof from cached tags (T-987) ... Implement the D-230 on-demand derive phase (data-production half). New atlas/shell.rs derives a sparse building shell for one 64 m chunk from the plan-phase BuildingPropertyTags: rectangle-containment (footprint ∩ chunk) × z-range (per-floor voxel bands from FloorExtent), in a quarter-ground z frame (D-110). Walls on the footprint perimeter, FloorSlab on interior floor bases, Roof above the top floor; interior air is Void and never stored. - gen_queue.rs: GenWorkItem::FillChunk carries pre-resolved block_tags + block_pos + sub_chunk (run_work_item stays cache-free, mirroring GenerateSkeleton); GenCompletion::ChunkFilled carries Box<FilledChunk>; the arm calls shell::fill_chunk; pure build_fill_chunk_item(&QuarterWorldState,..) added. - plugin.rs: ChunkFilled handler accepts the shell (trace-only — the Phase-5 rendering consumer and the on-demand streaming dispatch trigger are deferred; do not build on legacy chunk_streaming.rs before Phase 5, gated by T-962). Tests: determinism, sparsity-vs-dense-volume, wall/floor/roof correctness, basement z-origin, sub-chunk clipping, full submit→drain→ChunkFilled round-trip. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-27 23:34:46 +02:00