fix(client): move golden-provenance key out of scenarios{} — crashed visual_capture --list (PR #180 review, Hoshe)

The _comment_atlas_goldens key inside scenarios{} hit _print_list's .get() on a bare String (reproduced: Invalid call on String at visual_capture.gd:699). Moved to a top-level key alongside resolution/golden_dir; _print_list now also skips _-prefixed and non-Dictionary entries so future comment keys cannot crash it. Verified: --list runs clean, JSON valid. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-16 21:40:03 +02:00
parent 3819e65759
commit fcf913a413
2 changed files with 6 additions and 1 deletions
@@ -696,6 +696,11 @@ func _print_list() -> void:
 	var flows: Dictionary = _config.get("flows", {})
 	print("scenarios:")
 	for name in scenarios:
+		# Skip "_"-prefixed comment keys and any non-Dictionary value — a bare
+		# string here crashed --list once (PR #180: a provenance _comment key
+		# placed inside scenarios{}; now top-level, but stay robust).
+		if String(name).begins_with("_") or not (scenarios[name] is Dictionary):
+			continue
 		var desc: String = scenarios[name].get("description", "")
 		print("  %s — %s" % [name, desc])
 	# T-1120: atlas_matrix isn't a tests/visual.json scenarios{} entry (it reads