fix(simulation): address PR #37 review — doc corrections, race fix, marker cleanup
Hoshe review (4 items): - types.rs: doc comment "Current: 6" → "Current: 9" - dialogue.rs: walk-away doc duplicated numbering (items 4-5 were 2-3) - test_world/mod.rs: comment "Reset plates at 49-51" → "49-55" - content_scaling.rs: magic number 51 → constants::RESET_PLATE_STABLE_IDS.1 Tyre review (3 items): - knowledge/types.rs: guard comments on decrement() floor at Hostile - input.rs: TeleportToHub now clears ConfrontationDelivered marker - content_scaling.rs: same magic number fix (covered above) Additional: - content_runtime.rs: barrier-based shutdown handshake fixes TCP RST race condition under parallel test execution - dialogue_room.rs: clippy type_complexity allow on NPCS tuple array Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -414,7 +414,7 @@ mod tests {
|
||||
assert!(registry.to_entity(&StableId(id)).is_some(), "Crowd Plaza at StableId {}", id);
|
||||
}
|
||||
|
||||
// Reset plates at 49-51
|
||||
// Reset plates at 49-55
|
||||
for id in constants::RESET_PLATE_STABLE_IDS.0..=constants::RESET_PLATE_STABLE_IDS.1 {
|
||||
assert!(
|
||||
registry.to_entity(&StableId(id)).is_some(),
|
||||
|
||||
@@ -28,6 +28,7 @@ const ORIGIN_X: i32 = 36;
|
||||
const ORIGIN_Y: i32 = 104;
|
||||
|
||||
/// NPC definitions: (name, rel_x, rel_y, want_kind, intensity, contentment, stress, threshold, location, role).
|
||||
#[allow(clippy::type_complexity)]
|
||||
const NPCS: &[(&str, i32, i32, WantKind, u8, i16, i16, i16, &str, &str)] = &[
|
||||
(
|
||||
"npc_dialogue_a", 8, 8, WantKind::Connection, 4, 20, 10, 60,
|
||||
|
||||
Reference in New Issue
Block a user