feat(ci): add golden file targets and checklist schema (#486, #497)

Golden targets: make golden-diff shows color diff if simulation output changed, make golden-update regenerates and stages for review. Checklist schema: JSON Schema for 7 condition types evaluable from ObserverSnapshot. Per-room YAML checklists for 3 Gauntlet rooms plus cross-room checks. Validation script + make checklist-validate/generate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-18 10:44:33 +01:00
parent 318a1e8b07
commit d8d005169a
8 changed files with 503 additions and 1 deletions
@@ -0,0 +1,130 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "$id": "checklist.schema.json",
+  "title": "Gauntlet QA Checklist",
+  "description": "Per-room QA checklist with conditions evaluable from ObserverSnapshot (D-030). Feeds into #503 auto-checklist progress tracking.",
+  "type": "object",
+  "required": ["conditions"],
+  "additionalProperties": false,
+  "properties": {
+    "room_id": {
+      "type": "string",
+      "pattern": "^[a-z][a-z0-9_]*$",
+      "description": "Room identifier matching constants.rs room name"
+    },
+    "room_name": {
+      "type": "string",
+      "minLength": 1,
+      "description": "Human-readable room name"
+    },
+    "description": {
+      "type": "string"
+    },
+    "conditions": {
+      "type": "array",
+      "items": {
+        "oneOf": [
+          { "$ref": "#/$defs/player_near" },
+          { "$ref": "#/$defs/player_facing" },
+          { "$ref": "#/$defs/entity_present" },
+          { "$ref": "#/$defs/entity_absent" },
+          { "$ref": "#/$defs/expected_monologue" },
+          { "$ref": "#/$defs/expected_dialogue" },
+          { "$ref": "#/$defs/expected_interaction_verb" }
+        ]
+      },
+      "minItems": 1
+    }
+  },
+  "$defs": {
+    "condition_id": {
+      "type": "string",
+      "pattern": "^[a-z][a-z0-9_-]*$",
+      "description": "Unique condition identifier within this checklist"
+    },
+    "player_near": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["id", "description", "condition_type", "x", "y", "radius"],
+      "properties": {
+        "id": { "$ref": "#/$defs/condition_id" },
+        "description": { "type": "string" },
+        "condition_type": { "const": "player_near" },
+        "x": { "type": "integer", "description": "Target X coordinate (absolute sim tiles)" },
+        "y": { "type": "integer", "description": "Target Y coordinate (absolute sim tiles)" },
+        "radius": { "type": "number", "minimum": 0, "description": "Proximity radius in tiles" }
+      }
+    },
+    "player_facing": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["id", "description", "condition_type", "direction"],
+      "properties": {
+        "id": { "$ref": "#/$defs/condition_id" },
+        "description": { "type": "string" },
+        "condition_type": { "const": "player_facing" },
+        "direction": {
+          "type": "string",
+          "enum": ["North", "South", "East", "West"],
+          "description": "Expected player facing direction"
+        }
+      }
+    },
+    "entity_present": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["id", "description", "condition_type", "entity_id"],
+      "properties": {
+        "id": { "$ref": "#/$defs/condition_id" },
+        "description": { "type": "string" },
+        "condition_type": { "const": "entity_present" },
+        "entity_id": { "type": "integer", "minimum": 0, "description": "StableId of expected entity" }
+      }
+    },
+    "entity_absent": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["id", "description", "condition_type", "entity_id"],
+      "properties": {
+        "id": { "$ref": "#/$defs/condition_id" },
+        "description": { "type": "string" },
+        "condition_type": { "const": "entity_absent" },
+        "entity_id": { "type": "integer", "minimum": 0, "description": "StableId of entity that should NOT be visible" }
+      }
+    },
+    "expected_monologue": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["id", "description", "condition_type", "contains"],
+      "properties": {
+        "id": { "$ref": "#/$defs/condition_id" },
+        "description": { "type": "string" },
+        "condition_type": { "const": "expected_monologue" },
+        "contains": { "type": "string", "minLength": 1, "description": "Substring expected in current_monologue text" }
+      }
+    },
+    "expected_dialogue": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["id", "description", "condition_type", "contains"],
+      "properties": {
+        "id": { "$ref": "#/$defs/condition_id" },
+        "description": { "type": "string" },
+        "condition_type": { "const": "expected_dialogue" },
+        "contains": { "type": "string", "minLength": 1, "description": "Substring expected in dialogue_response text" }
+      }
+    },
+    "expected_interaction_verb": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["id", "description", "condition_type", "entity_id", "verb"],
+      "properties": {
+        "id": { "$ref": "#/$defs/condition_id" },
+        "description": { "type": "string" },
+        "condition_type": { "const": "expected_interaction_verb" },
+        "entity_id": { "type": "integer", "minimum": 0, "description": "StableId of target entity" },
+        "verb": { "type": "string", "minLength": 1, "description": "Expected interaction verb (e.g., Talk, Pickup, Examine)" }
+      }
+    }
+  }
+}