From ce3778321db06013f634c730eeda7819b2830487 Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Fri, 13 Feb 2026 19:26:00 +0100 Subject: [PATCH] chore(skills): update review-pr skill Co-Authored-By: Claude Opus 4.6 --- .claude/skills/review-pr/SKILL.md | 32 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/.claude/skills/review-pr/SKILL.md b/.claude/skills/review-pr/SKILL.md index 773aee536..cf6fd1765 100644 --- a/.claude/skills/review-pr/SKILL.md +++ b/.claude/skills/review-pr/SKILL.md @@ -145,29 +145,27 @@ If no issues found, say APPROVE with a brief positive summary. ## 6. Posting results to Gitea -After presenting results to the user, post the review as a PR comment: - -```bash -tea comment --login schweitz --repo jpmschweitzer/settled-reach "" -``` - -Use a heredoc for multi-line review bodies: -```bash -tea comment --login schweitz --repo jpmschweitzer/settled-reach "$(cat <<'REVIEW' -## Review: -> main -...review content... -REVIEW -)" -``` +After presenting results to the user, post the review as a PR comment. Note: `tea pr reject` does not work on your own PRs. Use `tea comment` instead. -**Heredoc bodies hang** in `tea comment`. Write review to a temp file instead: +**IMPORTANT — `tea comment` hangs with inline heredocs and multi-line strings.** +Always use a two-step approach: write to a temp file first, then pass via `$(cat)`: + ```bash -# Write review to temp file, then pass via cat -tea comment --login schweitz --repo jpmschweitzer/settled-reach "$(cat /tmp/review.md)" +# Step 1: Write review to temp file (use Bash heredoc, NOT the Write tool) +cat > /tmp/review-.md << 'EOF' +## Review: -> main +...review content... +EOF + +# Step 2: Post to Gitea (separate Bash call) +tea comment --login schweitz --repo jpmschweitzer/settled-reach "$(cat /tmp/review-.md)" ``` +These MUST be separate sequential Bash calls — do not chain them in a single +command. The heredoc write must complete before `tea comment` reads the file. + ## 7. Merging approved PRs `tea pr merge` fails (405) when branches have conflicts with main. Merge