From c55474f46d440a235a4c04f549b8bc5b4ec1c9aa Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Wed, 25 Feb 2026 02:42:43 +0100 Subject: [PATCH] =?UTF-8?q?fix(content):=20PR=20#64=20review=20=E2=80=94?= =?UTF-8?q?=20schema=20compliance=20and=20orphaned=20flags?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix events_fired referencing flag names instead of event IDs (two outcomes unreachable). Wire 4 orphaned flags into narratively coupled outcome conditions. Fix typo and stale question count. Co-Authored-By: Claude Opus 4.6 --- .../modules/tier1/smuggling_ring_v0_1.yaml | 21 ++++++++++++------- decisions/README.md | 2 +- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/content/modules/tier1/smuggling_ring_v0_1.yaml b/content/modules/tier1/smuggling_ring_v0_1.yaml index 64526e8cb..7834b25a3 100644 --- a/content/modules/tier1/smuggling_ring_v0_1.yaml +++ b/content/modules/tier1/smuggling_ring_v0_1.yaml @@ -455,7 +455,7 @@ events: fact_id: "ring.sera_avoidance_behavior" discoverable_by: detective discovery_method: > - Observer Sera's path through the bar on two separate occasions. + Observe Sera's path through the bar on two separate occasions. Requires forward vision cone and awareness of her baseline route. once: false @@ -504,8 +504,9 @@ outcomes: - "ring.cargo_discrepancy_pattern" - "ring.kael_unauthorized_corridor_access" - "ring.voss_kael_private_meeting" - events_fired: - - secret_meeting_occurred + flags_set: + - secret_meeting_occurred # set by kael_secret_meeting event + - commission_flag_exists # Commission was watching before exposure effects: - type: npc_disposition npc_role: ring-leader @@ -544,8 +545,9 @@ outcomes: facts_known: - "ring.kael_unauthorized_corridor_access" flags_set: - - secret_meeting_occurred - - voss_pressure_applied + - kael_behavior_changed # set by kael_goes_cold — his exit arc begins here + - secret_meeting_occurred # set by kael_secret_meeting — the pivot moment + - voss_pressure_applied # set by ring_leader_confronts_kael — pressure applied # ring_exposed is checked first in the outcomes list and is terminal, # so kael_escapes only evaluates if ring_exposed hasn't fired. # No flags_not_set needed here — outcome ordering handles priority. @@ -575,8 +577,9 @@ outcomes: The smuggler completes their last run and waits to see if there's another. Unsatisfying only if you expected a tidy resolution. The world moved on. conditions: - events_fired: - - final_shipment_known + flags_set: + - final_shipment_known # set by final_shipment_scheduled event + - timeline_accelerating # set by maret_increases_presence — Maret forced their hand flags_not_set: - kael_message_sent # If this is NOT set, Kael's cooperation went unnoticed ticks_since_activation: 3600 # Module ran for ~60 minutes without full exposure @@ -610,7 +613,9 @@ outcomes: facts_known: - "ring.cargo_discrepancy_pattern" events_fired: - - kael_goes_cold + - kael_goes_cold # event ID — Kael's behavioral shift fired + flags_set: + - kael_missed_drop # set by drop_happens_without_kael — ring destabilized flags_not_set: - kael_message_sent ticks_since_activation: 2400 diff --git a/decisions/README.md b/decisions/README.md index eed582653..fa69fe58a 100644 --- a/decisions/README.md +++ b/decisions/README.md @@ -15,7 +15,7 @@ Cross-domain decisions live in one file with cross-reference notes in related fi | [content.md](content.md) | NPC, dialogue, templates | D-023, D-024, D-025, D-028, D-029, D-032, D-034, D-035, D-036, D-037, D-050, D-062, D-063, D-064, D-074, D-075, D-084 | | [scope.md](scope.md) | Game concept, prototype | D-001, D-003, D-005, D-006, D-007, D-013, D-014, D-027, D-038, D-039, D-051, D-053, D-065 | | [process.md](process.md) | Team, workflow | D-004, D-021, D-022, D-040 | -| [questions.md](questions.md) | Open questions | Q-001 through Q-026 | +| [questions.md](questions.md) | Open questions | Q-001 through Q-028 | | [rejected.md](rejected.md) | Rejected alternatives | R-001 through R-010 | ## Querying Decisions