fix(client): address PR #4 review feedback

Hoshe critical fixes:
- _action_enum_to_wire uses InputMapper.Action constants instead of
  fragile integer literals; OPEN_MENU explicitly handled as client-only
- Remove int() coercion on tick/entity_id — use direct assignment since
  GDScript int is signed 64-bit (safe for realistic tick values)
- Check encode result before buffering in send_input() — reject empty
  bytes instead of corrupting the outbound stream
- Test snapshot now uses Protocol format {tick, entities} instead of
  legacy schema; GameState updated to derive player position from
  entity data; main.gd and world_renderer.gd updated accordingly

Hoshe warnings:
- 5 negative tests added (truncated bytes, wrong type, missing fields,
  empty bytes, encode validation) — 20/20 tests pass
- receive_bytes signal is emitted at consume time in poll_snapshot by
  design (documented in code)

Tyre suggestions:
- Remove duplicated root-level fixtures — single source of truth in
  client/tests/fixtures/msgpack/
- gen_fixtures.rs writes directly to client/ directory
- Add `make fixtures` target for regeneration

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

This commit is contained in:

jpmschweitzer

2026-02-11 19:32:49 +01:00

co-authored by

Claude Opus 4.6

parent 9af9b3f3aa

commit bc9a691bc1

15 changed files with 109 additions and 89 deletions

									
										Makefile
									
		+3
		
												View File
												
				@@ -73,6 +73,9 @@ test: test-server test-client

				test-server:

					cd server && cargo nextest run

				fixtures:

					cd server && cargo test --test gen_fixtures -- --ignored

				test-client:

					@test -n "$(GODOT)" || { echo "Godot not found. Run 'make setup' first."; exit 1; }

					$(GODOT) --headless --path client -s res://addons/gdUnit4/bin/GdUnitCmdTool.gd --ignoreHeadlessMode -a res://tests/