fix(simulation): Clippy cleanup and CI enforcement (#635)

Fix all Clippy warnings across the server codebase (2411 insertions, 1341
deletions). Raise type-complexity-threshold to 750 and too-many-arguments
to 12 in .clippy.toml for idiomatic Bevy ECS system signatures. The server
now passes `cargo clippy -- --deny warnings` cleanly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

server/tests/voice_quality_batch.rs

@@ -15,8 +15,8 @@ use settled_reach_server::npc::blueprint::{
     CulturalValues, CultureProfile, NamingConventions, OccasionalInjection, SpeechPatterns,
     VoiceExample,
 };
-use settled_reach_server::npc::PersonalityTrait;
 use settled_reach_server::npc::tell_state::TellCategory;
+use settled_reach_server::npc::PersonalityTrait;
 use settled_reach_server::voice::cache::{CacheKey, VoiceCacheStore};
 use settled_reach_server::voice::prompt_builder::ContentType;
 use settled_reach_server::voice::queue::{Priority, VoiceQueue, VoiceRequest};
@@ -106,8 +106,9 @@ fn van_maanens_star_culture() -> CultureProfile {
         ],
         occasional_injections: vec![OccasionalInjection {
             kind: "oath".into(),
-            clause: "Use an oath like \"void take it\" when something is surprising or frustrating."
-                .into(),
+            clause:
+                "Use an oath like \"void take it\" when something is surprising or frustrating."
+                    .into(),
             example: Some(VoiceExample {
                 input: "discovers a critical part is missing".into(),
                 output: "Void take it. The coupling's not here.".into(),
@@ -623,13 +624,20 @@ fn voice_quality_batch() {
             .unwrap_or("[MISSING — not cached]");
 
         output.push_str(&format!("--- #{}: {} ---\n", i + 1, case.label));
-        output.push_str(&format!("  tell: {:?} | seed: {} | type: {:?}\n", case.tell_state, case.seed, case.content_type));
+        output.push_str(&format!(
+            "  tell: {:?} | seed: {} | type: {:?}\n",
+            case.tell_state, case.seed, case.content_type
+        ));
         output.push_str(&format!("  BASE:   {}\n", case.base_text));
         output.push_str(&format!("  VOICED: {}\n\n", voiced));
     }
 
     drop(cache_guard);
-    cache.lock().unwrap().save_all().expect("failed to save cache");
+    cache
+        .lock()
+        .unwrap()
+        .save_all()
+        .expect("failed to save cache");
 
     let results_path = out.join("quality-batch.txt");
     std::fs::write(&results_path, &output).expect("failed to write results");