fix(simulation): Clippy cleanup and CI enforcement (#635)

Fix all Clippy warnings across the server codebase (2411 insertions, 1341
deletions). Raise type-complexity-threshold to 750 and too-many-arguments
to 12 in .clippy.toml for idiomatic Bevy ECS system signatures. The server
now passes `cargo clippy -- --deny warnings` cleanly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

server/tests/contamination.rs

@@ -7,12 +7,12 @@ use bevy_ecs::prelude::*;
 use bevy_ecs::schedule::Schedule;
 use std::collections::BTreeMap;
 
-use settled_reach_server::simulation::triangle::{
-    RoleId, TemplateId, TriangleClassification, TriangleId, TrianglePhase, TriangleState,
-};
 use settled_reach_server::knowledge::types::StableId;
 use settled_reach_server::simulation::tier::ActiveSim;
 use settled_reach_server::simulation::time::SimulationTime;
+use settled_reach_server::simulation::triangle::{
+    RoleId, TemplateId, TriangleClassification, TriangleId, TrianglePhase, TriangleState,
+};
 use settled_reach_server::storyteller::{
     tick_contamination_activation, ContaminationActive, ContaminationEventQueue,
     CONTAMINATION_DELAY_TICKS, CONTAMINATION_PRESSURE_DELTA,
@@ -112,11 +112,15 @@ fn contamination_activates_after_delay() {
     assert!(
         world.resource::<ContaminationActive>().0,
         "ContaminationActive must be true after CONTAMINATION_DELAY_TICKS ({}) ticks",
-            CONTAMINATION_DELAY_TICKS
+        CONTAMINATION_DELAY_TICKS
     );
 
     // Assert all ActiveFork triangles have tension > 0
-    for (label, entity) in [("hub-power", fork1), ("bar-tensions", fork2), ("informant-question", fork3)] {
+    for (label, entity) in [
+        ("hub-power", fork1),
+        ("bar-tensions", fork2),
+        ("informant-question", fork3),
+    ] {
         let state = world
             .get::<TriangleState>(entity)
             .unwrap_or_else(|| panic!("{} triangle entity should exist", label));
@@ -129,13 +133,15 @@ fn contamination_activates_after_delay() {
         assert_eq!(
             state.tension, CONTAMINATION_PRESSURE_DELTA,
             "ActiveFork triangle '{}' tension should be exactly {} (contamination delta)",
-            label,
-            CONTAMINATION_PRESSURE_DELTA
+            label, CONTAMINATION_PRESSURE_DELTA
         );
     }
 
     // Assert PassiveTension triangles were NOT pressured
-    for (label, entity) in [("worried-knowledge", passive1), ("worried-partner", passive2)] {
+    for (label, entity) in [
+        ("worried-knowledge", passive1),
+        ("worried-partner", passive2),
+    ] {
         let state = world
             .get::<TriangleState>(entity)
             .unwrap_or_else(|| panic!("{} triangle entity should exist", label));