fix(simulation): Clippy cleanup and CI enforcement (#635)

Fix all Clippy warnings across the server codebase (2411 insertions, 1341
deletions). Raise type-complexity-threshold to 750 and too-many-arguments
to 12 in .clippy.toml for idiomatic Bevy ECS system signatures. The server
now passes `cargo clippy -- --deny warnings` cleanly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

server/src/simulation/poi_discovery.rs

@@ -152,11 +152,7 @@ mod tests {
     use crate::simulation::poi::{PoiCategory, PoiDiscoverySource};
     use std::collections::BTreeSet;
 
-    fn make_poi(
-        id: &str,
-        position: TilePosition,
-        visibility: PoiVisibility,
-    ) -> PointOfInterest {
+    fn make_poi(id: &str, position: TilePosition, visibility: PoiVisibility) -> PointOfInterest {
         PointOfInterest {
             poi_id: id.to_string(),
             name: format!("Test {}", id),
@@ -181,7 +177,11 @@ mod tests {
     #[test]
     fn los_poi_discovered_when_in_visible_positions() {
         let observer_pos = TilePosition::new(5, 5, 0);
-        let poi = make_poi("bay", TilePosition::new(10, 5, 0), PoiVisibility::LineOfSight);
+        let poi = make_poi(
+            "bay",
+            TilePosition::new(10, 5, 0),
+            PoiVisibility::LineOfSight,
+        );
         let geometry = make_geometry(&[(10, 5)], 0);
         let kg = KnowledgeGraph::new();
 
@@ -191,7 +191,11 @@ mod tests {
     #[test]
     fn los_poi_not_discovered_when_not_visible() {
         let observer_pos = TilePosition::new(5, 5, 0);
-        let poi = make_poi("bay", TilePosition::new(10, 5, 0), PoiVisibility::LineOfSight);
+        let poi = make_poi(
+            "bay",
+            TilePosition::new(10, 5, 0),
+            PoiVisibility::LineOfSight,
+        );
         let geometry = make_geometry(&[(8, 5)], 0); // (10,5) not in visible set
         let kg = KnowledgeGraph::new();
 
@@ -201,7 +205,11 @@ mod tests {
     #[test]
     fn los_poi_not_discovered_on_different_z() {
         let observer_pos = TilePosition::new(5, 5, 0);
-        let poi = make_poi("bay", TilePosition::new(10, 5, 1), PoiVisibility::LineOfSight);
+        let poi = make_poi(
+            "bay",
+            TilePosition::new(10, 5, 1),
+            PoiVisibility::LineOfSight,
+        );
         let geometry = make_geometry(&[(10, 5)], 0); // observer on z=0, poi on z=1
         let kg = KnowledgeGraph::new();
 
@@ -371,7 +379,10 @@ mod tests {
         let mut query = world.query_filtered::<&KnowledgeGraph, With<PlayerCharacter>>();
         let kg = query.single(&world).expect("player should exist");
         let fact_id = FactId("poi.docking_bay".to_string());
-        assert!(kg.knows_fact(&fact_id), "Player should know poi.docking_bay");
+        assert!(
+            kg.knows_fact(&fact_id),
+            "Player should know poi.docking_bay"
+        );
         assert_eq!(
             kg.facts.get(&fact_id).unwrap().confidence,
             KnowledgeConfidence::KnowsOf