fix(simulation): Clippy cleanup and CI enforcement (#635)

Fix all Clippy warnings across the server codebase (2411 insertions, 1341
deletions). Raise type-complexity-threshold to 750 and too-many-arguments
to 12 in .clippy.toml for idiomatic Bevy ECS system signatures. The server
now passes `cargo clippy -- --deny warnings` cleanly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

server/src/simulation/line_pool.rs

@@ -467,10 +467,19 @@ mod tests {
     #[test]
     fn access_tier_parse_all_values() {
         assert_eq!("public".parse::<AccessTier>().unwrap(), AccessTier::Public);
-        assert_eq!("insider".parse::<AccessTier>().unwrap(), AccessTier::Insider);
-        assert_eq!("authority".parse::<AccessTier>().unwrap(), AccessTier::Authority);
+        assert_eq!(
+            "insider".parse::<AccessTier>().unwrap(),
+            AccessTier::Insider
+        );
+        assert_eq!(
+            "authority".parse::<AccessTier>().unwrap(),
+            AccessTier::Authority
+        );
         assert_eq!("peer".parse::<AccessTier>().unwrap(), AccessTier::Peer);
-        assert_eq!("hostile".parse::<AccessTier>().unwrap(), AccessTier::Hostile);
+        assert_eq!(
+            "hostile".parse::<AccessTier>().unwrap(),
+            AccessTier::Hostile
+        );
         assert!("invalid".parse::<AccessTier>().is_err());
     }
 
@@ -486,12 +495,29 @@ mod tests {
     #[test]
     fn situation_parse_all_values() {
         let values = [
-            "arrival", "shift_start", "shift_end", "shift_transition", "bar_evening",
-            "night_shift", "investigation", "confrontation", "social", "alone",
-            "emergency", "routine", "observation", "greeting", "first_meeting", "repeated_visit",
+            "arrival",
+            "shift_start",
+            "shift_end",
+            "shift_transition",
+            "bar_evening",
+            "night_shift",
+            "investigation",
+            "confrontation",
+            "social",
+            "alone",
+            "emergency",
+            "routine",
+            "observation",
+            "greeting",
+            "first_meeting",
+            "repeated_visit",
         ];
         for v in values {
-            assert!(v.parse::<Situation>().is_ok(), "Failed to parse situation: {}", v);
+            assert!(
+                v.parse::<Situation>().is_ok(),
+                "Failed to parse situation: {}",
+                v
+            );
         }
         assert!("invalid".parse::<Situation>().is_err());
     }
@@ -499,8 +525,15 @@ mod tests {
     #[test]
     fn topic_parse_all_values() {
         let values = [
-            "colleague", "routine", "cargo", "money", "trust", "danger",
-            "institution", "personal", "investigation",
+            "colleague",
+            "routine",
+            "cargo",
+            "money",
+            "trust",
+            "danger",
+            "institution",
+            "personal",
+            "investigation",
         ];
         for v in values {
             assert!(v.parse::<Topic>().is_ok(), "Failed to parse topic: {}", v);
@@ -510,8 +543,14 @@ mod tests {
     #[test]
     fn mood_parse_all_values() {
         let values = [
-            "anxious", "frustrated", "content", "suspicious", "warm",
-            "hostile", "relieved", "focused",
+            "anxious",
+            "frustrated",
+            "content",
+            "suspicious",
+            "warm",
+            "hostile",
+            "relieved",
+            "focused",
         ];
         for v in values {
             assert!(v.parse::<Mood>().is_ok(), "Failed to parse mood: {}", v);
@@ -521,19 +560,35 @@ mod tests {
     #[test]
     fn trigger_parse_all_values() {
         let values = [
-            "enter_location", "observe_npc", "hear_sound", "observe_anomaly",
-            "post_conversation", "discover_evidence", "witness_interaction",
-            "time_idle", "return_visit",
+            "enter_location",
+            "observe_npc",
+            "hear_sound",
+            "observe_anomaly",
+            "post_conversation",
+            "discover_evidence",
+            "witness_interaction",
+            "time_idle",
+            "return_visit",
         ];
         for v in values {
-            assert!(v.parse::<Trigger>().is_ok(), "Failed to parse trigger: {}", v);
+            assert!(
+                v.parse::<Trigger>().is_ok(),
+                "Failed to parse trigger: {}",
+                v
+            );
         }
     }
 
     #[test]
     fn character_parse() {
-        assert_eq!("smuggler".parse::<Character>().unwrap(), Character::Smuggler);
-        assert_eq!("detective".parse::<Character>().unwrap(), Character::Detective);
+        assert_eq!(
+            "smuggler".parse::<Character>().unwrap(),
+            Character::Smuggler
+        );
+        assert_eq!(
+            "detective".parse::<Character>().unwrap(),
+            Character::Detective
+        );
         assert!("other".parse::<Character>().is_err());
     }
 }