fix(simulation): Clippy cleanup and CI enforcement (#635)

Fix all Clippy warnings across the server codebase (2411 insertions, 1341
deletions). Raise type-complexity-threshold to 750 and too-many-arguments
to 12 in .clippy.toml for idiomatic Bevy ECS system signatures. The server
now passes `cargo clippy -- --deny warnings` cleanly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

server/src/npc/awareness.rs

@@ -28,8 +28,8 @@ use serde::{Deserialize, Serialize};
 
 use crate::npc::vision::NpcVisionState;
 use crate::npc::{Npc, ToleranceThreshold};
-use crate::simulation::time::SimulationTime;
 use crate::simulation::tier::ActiveSim;
+use crate::simulation::time::SimulationTime;
 
 // ---------------------------------------------------------------------------
 // Constants
@@ -117,7 +117,7 @@ pub fn detect_player_awareness(
             awareness.consecutive_los_ticks = 0;
 
             // Decay suspicion slowly when player is not visible
-            if time.tick % AWARENESS_DECAY_INTERVAL == 0 && awareness.suspicion_level > 0 {
+            if time.tick.is_multiple_of(AWARENESS_DECAY_INTERVAL) && awareness.suspicion_level > 0 {
                 awareness.suspicion_level =
                     (awareness.suspicion_level - AWARENESS_DECAY_AMOUNT).max(0);
             }
@@ -134,8 +134,8 @@ mod tests {
     use super::*;
     use crate::npc::vision::NpcVisionState;
     use crate::npc::{Npc, ToleranceThreshold};
-    use crate::simulation::time::SimulationTime;
     use crate::simulation::tier::ActiveSim;
+    use crate::simulation::time::SimulationTime;
     use bevy_ecs::world::World;
 
     fn setup_world() -> World {
@@ -372,7 +372,10 @@ mod tests {
         run_system(&mut world);
 
         let awareness = world.get::<PlayerAwareness>(npc).unwrap();
-        assert_eq!(awareness.suspicion_level, 100, "suspicion should cap at 100");
+        assert_eq!(
+            awareness.suspicion_level, 100,
+            "suspicion should cap at 100"
+        );
     }
 
     #[test]