fix(simulation): Clippy cleanup and CI enforcement (#635)

Fix all Clippy warnings across the server codebase (2411 insertions, 1341
deletions). Raise type-complexity-threshold to 750 and too-many-arguments
to 12 in .clippy.toml for idiomatic Bevy ECS system signatures. The server
now passes `cargo clippy -- --deny warnings` cleanly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

server/src/main.rs

@@ -165,7 +165,10 @@ fn main() {
             ));
         }
         Err(e) => {
-            tracing::error!("Failed to open settings store: {}. Settings will not persist.", e);
+            tracing::error!(
+                "Failed to open settings store: {}. Settings will not persist.",
+                e
+            );
         }
     }
 
@@ -176,9 +179,11 @@ fn main() {
     app.insert_resource(settled_reach_server::simulation::rng::SimRng::new(seed));
 
     // Initialize empty line pool index (populated by generator pipeline in v0.2).
-    app.insert_resource(settled_reach_server::simulation::line_pool::LinePoolIndexResource(
-        settled_reach_server::simulation::line_pool::LinePoolIndex::default(),
-    ));
+    app.insert_resource(
+        settled_reach_server::simulation::line_pool::LinePoolIndexResource(
+            settled_reach_server::simulation::line_pool::LinePoolIndex::default(),
+        ),
+    );
 
     // Character archetype from client's StartupMessage (#587).
     let archetype = startup.character_archetype;
@@ -384,7 +389,10 @@ fn dump_schedule_graph() {
 
 /// Proof room: 32x32 map, wall at (16,14), player at (16,16), 3 NPCs.
 /// Extracted from the original inline setup for reuse by both test-mode and normal mode.
-fn setup_proof_room(app: &mut App, archetype: settled_reach_server::bridge::types::CharacterArchetype) {
+fn setup_proof_room(
+    app: &mut App,
+    archetype: settled_reach_server::bridge::types::CharacterArchetype,
+) {
     use settled_reach_server::knowledge::registry::EntityRegistry;
     use settled_reach_server::knowledge::KnowledgeGraph;
     use settled_reach_server::npc::relationships::{RelationshipEdge, RelationshipGraph};
@@ -418,11 +426,17 @@ fn setup_proof_room(app: &mut App, archetype: settled_reach_server::bridge::type
 
     // Player at (16,16) — archetype from StartupMessage (#587, D-053)
     let profile = match archetype {
-        settled_reach_server::bridge::types::CharacterArchetype::Smuggler => MovementProfile::smuggler(),
-        settled_reach_server::bridge::types::CharacterArchetype::Detective => MovementProfile::detective(),
+        settled_reach_server::bridge::types::CharacterArchetype::Smuggler => {
+            MovementProfile::smuggler()
+        }
+        settled_reach_server::bridge::types::CharacterArchetype::Detective => {
+            MovementProfile::detective()
+        }
+    };
+    let monologue_state = MonologueState {
+        character: archetype.as_monologue_key().to_string(),
+        ..Default::default()
     };
-    let mut monologue_state = MonologueState::default();
-    monologue_state.character = archetype.as_monologue_key().to_string();
     let player = app
         .world_mut()
         .spawn((