fix(ui): PR #217 review fixes — derived legend offset, 960x540 goldens, non-overlap tests

Browse Source

The legend's reposition() now derives its Y from the header panel's
MEASURED bottom plus a named 12px gap (new accessors on the viewer;
deferred recompute so it reads settled layout, refreshed on header
content change) — the old hardcoded 60.0 sat 17px inside the wrapped
header's real 77px bottom, fusing the panels. Pixel-proven at the
evidence center: bottom=77.0, legend top=89.0, gap=12.0 exact. All 13
goldens regenerated at the DOCUMENTED 960x540 (the 1280x720 rider was
my own CLI flag, not a config; PIL-verified) with two-run byte
stability. Two structural tests pin the header/legend relationship
(T-1192 precedent), proven failing-first against the old constant
(-17.0px reported), and the legacy test that pinned the literal 60.0
now asserts the derived relationship so it cannot re-enforce drift.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

...

This commit is contained in:

jpmschweitzer

2026-07-26 15:13:11 +02:00

co-authored by Claude Fable 5

parent 34ecdad46f

commit a4d9a4fa09

17 changed files with 176 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

client/tests/golden/visual/atlas_GJ144e_Global.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 52 KiB After Width:  |  Height:  |  Size: 41 KiB

client/tests/golden/visual/atlas_GJ144e_Quarter.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 153 KiB After Width:  |  Height:  |  Size: 80 KiB

client/tests/golden/visual/atlas_GJ244Ad_Global.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 40 KiB After Width:  |  Height:  |  Size: 28 KiB

client/tests/golden/visual/atlas_GJ251c_Global.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 46 KiB After Width:  |  Height:  |  Size: 32 KiB

client/tests/golden/visual/atlas_GJ251c_Region.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 55 KiB After Width:  |  Height:  |  Size: 43 KiB

client/tests/golden/visual/atlas_GJ338Bd_Block.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 218 KiB After Width:  |  Height:  |  Size: 110 KiB

client/tests/golden/visual/atlas_GJ338Bd_Global.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 90 KiB After Width:  |  Height:  |  Size: 75 KiB

client/tests/golden/visual/atlas_GJ380c_District.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 487 KiB After Width:  |  Height:  |  Size: 243 KiB

client/tests/golden/visual/atlas_GJ380c_Global.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 60 KiB After Width:  |  Height:  |  Size: 43 KiB

client/tests/golden/visual/atlas_GJ380c_Region.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 78 KiB After Width:  |  Height:  |  Size: 63 KiB

client/tests/golden/visual/atlas_GJ445c-m1_Chunk.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 121 KiB After Width:  |  Height:  |  Size: 70 KiB

client/tests/golden/visual/atlas_GJ820Bc_District.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.3 MiB After Width:  |  Height:  |  Size: 656 KiB

client/tests/golden/visual/atlas_GJ820Bc_Global.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 56 KiB After Width:  |  Height:  |  Size: 41 KiB