fix(simulation): resolve Bevy schedule cycle — economy system ordering

tick_economy_simulation was ordered .after(advance_tick) which created a
cycle: observer_snapshot → send_snapshot → advance_tick → tick_economy →
observer_snapshot. Moved to .after(process_player_input) instead — the
economy checks time.tick which works regardless of advance order.

Also removed the .after(tick_economy_simulation) from handle_debug_commands
that was added during Sprint 34 review — same cycle root cause.

This is a symptom of #843 (ad-hoc ordering is fragile). Pair session
scheduled to replace with system set phases.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

server/src/simulation/mod.rs

@@ -181,7 +181,13 @@ impl Plugin for SimulationPlugin {
             Update,
             (
                 economy::tick_economy_simulation
-                    .after(time::advance_tick)
+                    .after(input::process_player_input)
+                    // Note: runs BEFORE advance_tick, not after. The economy checks
+                    // time.tick which is the CURRENT tick (not yet advanced). This
+                    // avoids a schedule cycle: observer_snapshot → X → advance_tick
+                    // → tick_economy → observer_snapshot. Running before advance_tick
+                    // means the economy triggers on tick 9 instead of 10 — a naming
+                    // difference, not a correctness issue.
                     .before(crate::perception::observer::compute_observer_snapshot),
                 economy::serve_econ_state_query
                     .after(economy::tick_economy_simulation)