fix(simulation): address PR #85 review — warnings and polish items

- Ticker rotation: document sliding-window semantics (vs modulus-aligned)
- Ticker zone ID: add warning about Gauntlet vs production zone ID mismatch
- Proof-room movement profile: respect archetype instead of hardcoding smuggler
- Storyteller tie-break: use exact f32 equality (inputs are discrete integers)
- Observer: .map().flatten() → .and_then() (clippy strict)
- Content loader: remove dangling doc comment before section header
- Tests: replace assert!(false, ...) with TODO comments in ignored tests
- Tests: add frame limiter note on 302-update loop in tell expiry test

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-05 10:59:38 +01:00
co-authored by Claude Opus 4.6
parent 37c38c0441
commit 9ed6094d69
7 changed files with 27 additions and 21 deletions
+4 -1
View File
@@ -399,7 +399,10 @@ fn setup_proof_room(app: &mut App, archetype: settled_reach_server::bridge::type
let mut registry = EntityRegistry::new(0);
// Player at (16,16) — archetype from StartupMessage (#587, D-053)
let profile = MovementProfile::smuggler();
let profile = match archetype {
settled_reach_server::bridge::types::CharacterArchetype::Smuggler => MovementProfile::smuggler(),
settled_reach_server::bridge::types::CharacterArchetype::Detective => MovementProfile::detective(),
};
let mut monologue_state = MonologueState::default();
monologue_state.character = archetype.as_monologue_key().to_string();
let player = app