style(client): gdformat all 52 GDScript files — zero format warnings

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-05 11:09:10 +02:00
parent 572e66f026
commit 88c7407cb6
52 changed files with 2323 additions and 1061 deletions
@@ -34,37 +34,50 @@ var _retry_timer: float = 0.0
 var _handshake_start_usec: int = 0

 var _test_tick: int:
-	get: return harness.tick if harness else 0
+	get:
+		return harness.tick if harness else 0
 	set(v):
-		if harness: harness.tick = v
+		if harness:
+			harness.tick = v

 var _test_player_pos: Vector2i:
-	get: return harness.player_pos if harness else Vector2i.ZERO
+	get:
+		return harness.player_pos if harness else Vector2i.ZERO
 	set(v):
-		if harness: harness.player_pos = v
+		if harness:
+			harness.player_pos = v

 var _test_facing: String:
-	get: return harness.facing if harness else "North"
+	get:
+		return harness.facing if harness else "North"
 	set(v):
-		if harness: harness.facing = v
+		if harness:
+			harness.facing = v

 var _test_in_dialogue: bool:
-	get: return harness.in_dialogue if harness else false
+	get:
+		return harness.in_dialogue if harness else false
 	set(v):
-		if harness: harness.in_dialogue = v
+		if harness:
+			harness.in_dialogue = v

 var _test_gauntlet_mode: bool:
-	get: return harness.gauntlet_mode if harness else false
+	get:
+		return harness.gauntlet_mode if harness else false
 	set(v):
-		if harness: harness.gauntlet_mode = v
+		if harness:
+			harness.gauntlet_mode = v

 var _test_npc_relationship: String:
-	get: return harness.npc_relationship if harness else "Unknown"
+	get:
+		return harness.npc_relationship if harness else "Unknown"
 	set(v):
-		if harness: harness.npc_relationship = v
+		if harness:
+			harness.npc_relationship = v

 var _test_input_queue: Array:
-	get: return harness.input_queue if harness else []
+	get:
+		return harness.input_queue if harness else []


 func _ready() -> void:
@@ -75,18 +88,23 @@ func _ready() -> void:

 # -- Test mode proxy API (backward compat for 13+ test files) ------------------

+
 func reset_test_state() -> void:
-	if harness: harness.reset()
+	if harness:
+		harness.reset()
+

 func _test_snapshot() -> Dictionary:
 	return harness.snapshot()

+
 func _test_has_los(from: Vector2i, to: Vector2i) -> bool:
 	return harness.has_los(from, to)


 # -- Connection lifecycle ------------------------------------------------------

+
 # Change connection state and emit signal
 func _set_state(new_state: ConnectionState) -> void:
 	if state != new_state:
@@ -94,6 +112,7 @@ func _set_state(new_state: ConnectionState) -> void:
 		state = new_state
 		connection_state_changed.emit(old_state, new_state)

+
 # Connect to simulation server.
 # In test mode, immediately transitions to CONNECTED.
 # In live mode, spawns server subprocess and defers TCP connection to _process()
@@ -125,6 +144,7 @@ func connect_to_sim() -> void:
 	_retry_timer = 0.0
 	_bridge = null

+
 # Disconnect from simulation server
 func disconnect_from_sim() -> void:
 	if _bridge != null:
@@ -136,15 +156,21 @@ func disconnect_from_sim() -> void:
 	_connect_retries = 0
 	_set_state(ConnectionState.DISCONNECTED)

+
 # Attempt TCP connection. Called from _process() during CONNECTING state.
 func _try_connect() -> void:
 	_bridge = LocalBridge.new()
 	var err := _bridge.connect_to_server("127.0.0.1", server_port)
 	if err != OK:
-		push_warning("SimBridge: TCP connect attempt %d/%d failed: %s" % [
-			_connect_retries + 1, MAX_CONNECT_RETRIES, error_string(err)])
+		push_warning(
+			(
+				"SimBridge: TCP connect attempt %d/%d failed: %s"
+				% [_connect_retries + 1, MAX_CONNECT_RETRIES, error_string(err)]
+			)
+		)
 		_bridge = null

+
 # Poll transport layer every frame (non-test mode only)
 func _process(delta: float) -> void:  # gdlint:disable=max-returns
 	if test_mode:
@@ -158,7 +184,9 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns
 				_retry_timer = 0.0
 				_connect_retries += 1
 				if _connect_retries > MAX_CONNECT_RETRIES:
-					push_error("SimBridge: TCP connection failed after %d retries" % MAX_CONNECT_RETRIES)
+					push_error(
+						"SimBridge: TCP connection failed after %d retries" % MAX_CONNECT_RETRIES
+					)
 					_set_state(ConnectionState.ERROR)
 					return
 				_try_connect()
@@ -176,7 +204,9 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns
 				# Connection attempt failed — retry
 				_bridge = null
 				if _connect_retries >= MAX_CONNECT_RETRIES:
-					push_error("SimBridge: TCP connection failed after %d retries" % MAX_CONNECT_RETRIES)
+					push_error(
+						"SimBridge: TCP connection failed after %d retries" % MAX_CONNECT_RETRIES
+					)
 					_set_state(ConnectionState.ERROR)
 			StreamPeerTCP.STATUS_NONE:
 				_bridge = null  # Reset and retry
@@ -191,7 +221,10 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns

 		# Check connection dropped during handshake
 		var bridge_status := _bridge.get_status()
-		if bridge_status == StreamPeerTCP.STATUS_ERROR or bridge_status == StreamPeerTCP.STATUS_NONE:
+		if (
+			bridge_status == StreamPeerTCP.STATUS_ERROR
+			or bridge_status == StreamPeerTCP.STATUS_NONE
+		):
 			var reason := "Connection dropped during handshake"
 			push_error("SimBridge: %s" % reason)
 			handshake_failed.emit(reason)
@@ -215,8 +248,11 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns

 		# Decode HandshakeMessage: { "protocol_version": N }
 		var decoded: Variant = Messagepack.decode(msg)
-		if decoded.status != null or not (decoded.value is Dictionary) \
-				or not decoded.value.has("protocol_version"):
+		if (
+			decoded.status != null
+			or not (decoded.value is Dictionary)
+			or not decoded.value.has("protocol_version")
+		):
 			var reason := "Handshake decode failed: malformed HandshakeMessage"
 			push_error("SimBridge: %s" % reason)
 			handshake_failed.emit(reason)
@@ -226,8 +262,10 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns

 		var server_version: int = decoded.value["protocol_version"]
 		if server_version != Protocol.PROTOCOL_VERSION:
-			var reason := "Protocol version mismatch: server=%d, client=%d" % [
-				server_version, Protocol.PROTOCOL_VERSION]
+			var reason := (
+				"Protocol version mismatch: server=%d, client=%d"
+				% [server_version, Protocol.PROTOCOL_VERSION]
+			)
 			push_error("SimBridge: %s" % reason)
 			handshake_failed.emit(reason)
 			_bridge.disconnect_from_server()
@@ -237,7 +275,10 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns
 		# Send startup message with world_seed and character appearance (#175, D-010/D-029, #718).
 		# Server blocks waiting for this before entering the tick loop.
 		var startup_bytes := Protocol.encode_startup_message(
-				GameState.world_seed, GameState.character_archetype, GameState.character_visual_descriptor)
+			GameState.world_seed,
+			GameState.character_archetype,
+			GameState.character_visual_descriptor
+		)
 		if startup_bytes.size() > 0:
 			var send_err := _bridge.send_message(startup_bytes)
 			if send_err != OK:
@@ -259,10 +300,15 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns
 		_set_state(ConnectionState.CONNECTED)
 		# #646: Request full settings dump on connect — hydrates GameState.ai_enhanced_dialogue_enabled
 		# from server SQLite so the client reflects the authoritative persisted state (D-138).
-		_outbound_buffer.append({
-			"tick": 0,
-			"action_name": "RequestAllSettings",
-		})
+		(
+			_outbound_buffer
+			. append(
+				{
+					"tick": 0,
+					"action_name": "RequestAllSettings",
+				}
+			)
+		)
 		return

 	if _bridge == null:
@@ -289,7 +335,9 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns
 					if err != OK:
 						push_error("SimBridge: failed to send message: %s" % error_string(err))
 				else:
-					push_error("SimBridge: failed to batch-encode %d inputs (dropped)" % outbound.size())
+					push_error(
+						"SimBridge: failed to batch-encode %d inputs (dropped)" % outbound.size()
+					)
 		StreamPeerTCP.STATUS_CONNECTING:
 			pass  # Should not happen in CONNECTED state
 		StreamPeerTCP.STATUS_ERROR:
@@ -304,6 +352,7 @@ func _process(delta: float) -> void:  # gdlint:disable=max-returns

 # -- Input / snapshot ----------------------------------------------------------

+
 # Send input to simulation server.
 # player_input: Dictionary with "action" (int from InputMapper.Action enum) and "timestamp_msec".
 # In test mode, inputs are delegated to the test harness.
@@ -330,13 +379,14 @@ func send_input(player_input: Dictionary) -> Error:
 	if action_name.is_empty():
 		return ERR_INVALID_PARAMETER
 	var tick: int = GameState.current_tick
-	var entry: Dictionary = { "tick": tick, "action_name": action_name }
+	var entry: Dictionary = {"tick": tick, "action_name": action_name}
 	var action_data: Variant = player_input.get("action_data")
 	if action_data != null:
 		entry["action_data"] = action_data
 	_outbound_buffer.append(entry)
 	return OK

+
 # Poll for snapshot from simulation.
 # In test mode delegates to test harness. In live mode, returns the last decoded snapshot.
 func poll_snapshot() -> Variant:
@@ -356,6 +406,7 @@ func poll_snapshot() -> Variant:

 	return null

+
 # Called by transport layer when raw bytes arrive from the server.
 # Latest-wins for positional state (stale frames are worthless), but one-shot
 # events (monologue, dialogue) are carried forward from overwritten snapshots
@@ -367,12 +418,21 @@ func receive_bytes(bytes: PackedByteArray) -> void:
 		return
 	if _last_snapshot != null:
 		# Carry forward one-shot events the client hasn't consumed yet.
-		if snapshot.get("current_monologue") == null and _last_snapshot.get("current_monologue") != null:
+		if (
+			snapshot.get("current_monologue") == null
+			and _last_snapshot.get("current_monologue") != null
+		):
 			snapshot["current_monologue"] = _last_snapshot["current_monologue"]
-		if snapshot.get("current_dialogue") == null and _last_snapshot.get("current_dialogue") != null:
+		if (
+			snapshot.get("current_dialogue") == null
+			and _last_snapshot.get("current_dialogue") != null
+		):
 			snapshot["current_dialogue"] = _last_snapshot["current_dialogue"]
 		# #535: Carry forward one-shot dialogue events (arrays merge, scalar falls through)
-		if snapshot.get("dialogue_response") == null and _last_snapshot.get("dialogue_response") != null:
+		if (
+			snapshot.get("dialogue_response") == null
+			and _last_snapshot.get("dialogue_response") != null
+		):
 			snapshot["dialogue_response"] = _last_snapshot["dialogue_response"]
 		var old_conv_events: Array = _last_snapshot.get("conversation_events", [])
 		if old_conv_events.size() > 0:
@@ -386,10 +446,14 @@ func receive_bytes(bytes: PackedByteArray) -> void:
 		if snapshot.get("save_result") == null and _last_snapshot.get("save_result") != null:
 			snapshot["save_result"] = _last_snapshot["save_result"]
 		# #646: Carry forward settings_response (one-shot, consumed by game_state apply_snapshot)
-		if snapshot.get("settings_response") == null and _last_snapshot.get("settings_response") != null:
+		if (
+			snapshot.get("settings_response") == null
+			and _last_snapshot.get("settings_response") != null
+		):
 			snapshot["settings_response"] = _last_snapshot["settings_response"]
 	_last_snapshot = snapshot

+
 # Drain the outbound buffer. Returns raw input entries for batch encoding.
 func drain_outbound() -> Array[Dictionary]:
 	var inputs = _outbound_buffer.duplicate()
@@ -399,24 +463,39 @@ func drain_outbound() -> Array[Dictionary]:

 # -- Wire protocol mapping -----------------------------------------------------

+
 # Map InputMapper.Action enum values to wire-format action names (matching Rust PlayerAction).
 # OPEN_MENU is client-only — no Rust equivalent, not sent over the wire.
 static func action_enum_to_wire(action: int) -> String:
 	match action:
-		InputMapper.Action.MOVE_NORTH: return "MoveNorth"
-		InputMapper.Action.MOVE_NORTHEAST: return "MoveNortheast"
-		InputMapper.Action.MOVE_EAST: return "MoveEast"
-		InputMapper.Action.MOVE_SOUTHEAST: return "MoveSoutheast"
-		InputMapper.Action.MOVE_SOUTH: return "MoveSouth"
-		InputMapper.Action.MOVE_SOUTHWEST: return "MoveSouthwest"
-		InputMapper.Action.MOVE_WEST: return "MoveWest"
-		InputMapper.Action.MOVE_NORTHWEST: return "MoveNorthwest"
-		InputMapper.Action.INTERACT: return "Interact"
-		InputMapper.Action.USE_PERCEPTION_MODE: return "UsePerceptionMode"
-		InputMapper.Action.PAUSE: return "Pause"
-		InputMapper.Action.UNPAUSE: return "Unpause"
-		InputMapper.Action.TOGGLE_STANCE_UP: return "ToggleStanceUp"
-		InputMapper.Action.TOGGLE_STANCE_DOWN: return "ToggleStanceDown"
+		InputMapper.Action.MOVE_NORTH:
+			return "MoveNorth"
+		InputMapper.Action.MOVE_NORTHEAST:
+			return "MoveNortheast"
+		InputMapper.Action.MOVE_EAST:
+			return "MoveEast"
+		InputMapper.Action.MOVE_SOUTHEAST:
+			return "MoveSoutheast"
+		InputMapper.Action.MOVE_SOUTH:
+			return "MoveSouth"
+		InputMapper.Action.MOVE_SOUTHWEST:
+			return "MoveSouthwest"
+		InputMapper.Action.MOVE_WEST:
+			return "MoveWest"
+		InputMapper.Action.MOVE_NORTHWEST:
+			return "MoveNorthwest"
+		InputMapper.Action.INTERACT:
+			return "Interact"
+		InputMapper.Action.USE_PERCEPTION_MODE:
+			return "UsePerceptionMode"
+		InputMapper.Action.PAUSE:
+			return "Pause"
+		InputMapper.Action.UNPAUSE:
+			return "Unpause"
+		InputMapper.Action.TOGGLE_STANCE_UP:
+			return "ToggleStanceUp"
+		InputMapper.Action.TOGGLE_STANCE_DOWN:
+			return "ToggleStanceDown"
 		InputMapper.Action.OPEN_MENU:
 			return ""  # Client-only action, not part of wire protocol
 		InputMapper.Action.BUG_REPORT:
@@ -432,11 +511,11 @@ static func action_enum_to_wire(action: int) -> String:
 		InputMapper.Action.DEBUG_COMMAND:
 			return "DebugCommand"  # #581: debug console command dispatch
 		InputMapper.Action.CHANGE_SETTINGS:
-			return "ChangeSettings"      # #646: persist setting to server SQLite (D-138)
+			return "ChangeSettings"  # #646: persist setting to server SQLite (D-138)
 		InputMapper.Action.REQUEST_ALL_SETTINGS:
 			return "RequestAllSettings"  # #646: unit variant — server sends full settings dump
 		InputMapper.Action.DELETE_SETTING:
-			return "DeleteSetting"       # #646: struct variant — delete setting by key
+			return "DeleteSetting"  # #646: struct variant — delete setting by key
 		_:
 			push_warning("SimBridge: unknown action enum %s" % action)
 			return ""