jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(client): use tick-based invalidation for world renderer

Browse Source 
Count-based dirty tracking missed content changes when tile/visibility
count stayed the same (e.g., door opening, player moving through
corridor). Now re-renders all layers when GameState.current_tick
advances, which correctly handles every snapshot change.

Adds 3 tests for tick advancement and same-count-different-content
scenarios. 68 total tests, 0 failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-02-12 00:24:30 +01:00
co-authored by Claude Opus 4.6
parent aa3a3fea7d
commit 6ff6be9a78
2 changed files with 34 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/scripts/rendering/world_renderer.gd
+11 -12
View File
@@ -8,30 +8,29 @@ extends Node2D
@onready var fog_renderer = $FogOverlay
@onready var entity_renderer = $Entities
var _last_tile_count: int = 0
var _last_visible_count: int = 0
var _last_tick: int = -1
func _ready() -> void:
print("WorldRenderer: Initialized")
# Called each frame to update visuals from game state
# Called each frame to update visuals from game state.
# Uses tick-based invalidation — re-renders all layers when a new snapshot arrives.
func update_from_state() -> void:
var tile_count := GameState.visible_tiles.size()
var visible_count := GameState.visible_positions.size()
var tick := GameState.current_tick
if tick == _last_tick:
return
_last_tick = tick
# Update tiles when tile data changes (new chunks loaded, D-012)
# Update tiles (may include new chunks or modified tiles)
if tile_renderer and tile_renderer.has_method("update_tiles"):
if tile_count > 0 and tile_count != _last_tile_count:
if GameState.visible_tiles.size() > 0:
tile_renderer.update_tiles(GameState.visible_tiles)
if fog_renderer and fog_renderer.has_method("register_tile_positions"):
fog_renderer.register_tile_positions(GameState.visible_tiles)
_last_tile_count = tile_count
# Update fog overlay when visibility changes
# Update fog overlay from visibility data
if fog_renderer and fog_renderer.has_method("update_fog"):
if visible_count != _last_visible_count:
fog_renderer.update_fog(GameState.visible_positions, GameState.player_position)
_last_visible_count = visible_count
fog_renderer.update_fog(GameState.visible_positions, GameState.player_position)
# Update entity sprites
if entity_renderer and entity_renderer.has_method("update_entities"):