fix(client): resolve all gdlint warnings — zero warnings policy

Fix 354 gdlint warnings across 65 files: 194 class-definitions-order
(reorder declarations), 138 max-line-length (split long lines),
22 code issues (unused args, no-else-return, naming). Update .gdlintrc
to exclude addons/ and raise max-public-methods for test files.
No logic changes — declaration order, whitespace, and naming only.

Ticket: #783

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

client/scripts/rendering/character_visual.gd

@@ -451,7 +451,8 @@ func _load_eyebrows(_desc: CharacterVisualDescriptor) -> void:
 	pass
 
 
-func _attach_to_bone(path: String, bone_name: String, tint: Color = Color.WHITE, render_priority: int = 0) -> BoneAttachment3D:
+func _attach_to_bone(
+		path: String, bone_name: String, tint: Color = Color.WHITE, _render_priority: int = 0) -> BoneAttachment3D:
 	if _skeleton == null:
 		return null
 	if not ResourceLoader.exists(path):
@@ -502,14 +503,13 @@ func _attach_to_bone(path: String, bone_name: String, tint: Color = Color.WHITE,
 			_apply_tinted_shader(mi, tint, mask_tex)
 		inst.queue_free()
 		return null
-	else:
-		# Unskinned — rigid attachment via BoneAttachment3D
-		for mi in meshes:
-			mi.get_parent().remove_child(mi)
-			mi.owner = null
-			attachment.add_child(mi)
-			_apply_tinted_shader(mi, tint, mask_tex)
-		inst.queue_free()
+	# Unskinned — rigid attachment via BoneAttachment3D
+	for mi in meshes:
+		mi.get_parent().remove_child(mi)
+		mi.owner = null
+		attachment.add_child(mi)
+		_apply_tinted_shader(mi, tint, mask_tex)
+	inst.queue_free()
 	return attachment
 
 
@@ -629,7 +629,8 @@ func _load_accessories(desc: CharacterVisualDescriptor) -> void:
 # Internal — tinting (hair, accessories, bone-attached assets with tint)
 # =============================================================================
 
-func _apply_tinted_shader(mi: MeshInstance3D, tint: Color, mask_tex: Texture2D = null, render_priority: int = 0) -> void:
+func _apply_tinted_shader(
+		mi: MeshInstance3D, tint: Color, mask_tex: Texture2D = null, _render_priority: int = 0) -> void:
 	if mi.mesh == null:
 		return
 	for surf in range(mi.mesh.get_surface_count()):

client/scripts/rendering/cursor_renderer.gd

@@ -5,19 +5,11 @@ extends Node2D
 ## Insert-styled cursor on z-layer 7 (UILayer CanvasLayer).
 ## Detects entity hover via world-space proximity to visible entities.
 
-enum State { DEFAULT, ENTITY_HOVER, OBJECT_HOVER, WEAPON_AIM }
-
-# --- Public ---
-var current_state: State = State.DEFAULT
-var hovered_entity_id: int = -1
-var weapon_mode_active: bool = false
-# OQ-07 (#522): when false, verb labels are suppressed (should_show_interactions → false).
-# Cursor shape transitions still fire — the character's body still orients to targets.
-var insert_active: bool = true
-
-signal state_changed(new_state: State)
+signal state_changed(new_state: int)
 signal hovered_entity_changed(entity_id: int)
 
+enum State { DEFAULT, ENTITY_HOVER, OBJECT_HOVER, WEAPON_AIM }
+
 # D-056 colors
 const COLOR_DEFAULT := Color("#c8d0e0")
 const COLOR_OBJECT := Color("#8b8ba0")
@@ -31,6 +23,14 @@ const HOVER_RADIUS_PX := 16.0  # World pixels — ~half a tile
 const BRACKET_HALF := 26.0
 const BRACKET_ARM := 8.0
 
+# --- Public ---
+var current_state: State = State.DEFAULT
+var hovered_entity_id: int = -1
+var weapon_mode_active: bool = false
+# OQ-07 (#522): when false, verb labels are suppressed (should_show_interactions → false).
+# Cursor shape transitions still fire — the character's body still orients to targets.
+var insert_active: bool = true
+
 # --- Transition state ---
 var _target: State = State.DEFAULT
 var _t: float = 1.0

client/scripts/rendering/entity_renderer.gd

@@ -25,6 +25,8 @@ const ENTITY_OFFSET_Y: float = TILE_SIZE - ENTITY_HEIGHT  # feet-anchored for co
 # At 12.0: ~70% there after 0.1s, ~95% after 0.25s.
 # Fast enough for Sprint snappiness, slow enough for Walk to show sliding.
 const LERP_SPEED: float = 12.0
+# #521: Color transition duration in seconds (D-033: "0.5s fade")
+const COLOR_FADE_DURATION: float = 0.5
 
 var entity_nodes: Dictionary = {}    # entity_id -> Node2D
 var _entity_targets: Dictionary = {} # entity_id -> Vector2 (target pixel position)
@@ -32,9 +34,6 @@ var _entity_relationships: Dictionary = {}  # #521: entity_id -> String (last re
 var _entity_tweens: Dictionary = {}  # #521: entity_id -> {from: Color, target: Color, elapsed: float}
 var _entity_facing: Dictionary = {}  # #540: entity_id -> String ("north"/"east"/"south"/"west")
 
-# #521: Color transition duration in seconds (D-033: "0.5s fade")
-const COLOR_FADE_DURATION: float = 0.5
-
 func _ready() -> void:
 	print("EntityRenderer: Initialized")
 
@@ -111,7 +110,8 @@ func _create_entity_node(entity_id: int, entity_data: Dictionary) -> void:
 	_entity_facing[entity_id] = direction
 	var tex := _load_sprite_texture(direction)
 	if tex == null:
-		push_error("EntityRenderer: no texture for entity %d direction '%s' — entity will be invisible" % [entity_id, direction])
+		push_error(
+				"EntityRenderer: no texture for entity %d direction '%s' — entity will be invisible" % [entity_id, direction])
 	entity_node.texture = tex
 
 	# D-033: self_modulate for relationship tinting; modulate.a is reserved for D-015 dimming.

client/scripts/rendering/fog_shader.gd

@@ -5,13 +5,14 @@ extends Node2D
 ## Architecture: docs/architecture/fog-shader-spec.md
 
 signal fog_noise_ready
+
+const TILE_SIZE := float(Constants.TILE_SIZE)
+
 var _noise_ready: bool = false
 
 var _fog_rect: ColorRect
 var _shader_mat: ShaderMaterial
 
-const TILE_SIZE := float(Constants.TILE_SIZE)
-
 
 func _ready() -> void:
 	# Create the fog overlay ColorRect — transparent fallback so a shader failure

client/scripts/rendering/tile_renderer.gd

@@ -11,11 +11,11 @@ extends TileMapLayer
 #   (3,0) = object      — teal
 #   (4,0) = reset_plate — amber (#502)
 
+enum TileType { FLOOR = 0, WALL = 1, DOOR = 2, OBJECT = 3, RESET_PLATE = 4 }
+
 const TILE_SIZE: int = Constants.TILE_SIZE
 const GROUND_FLOOR: int = 0  # Server floor level for ground — filter target in update_tiles()
 
-enum TileType { FLOOR = 0, WALL = 1, DOOR = 2, OBJECT = 3, RESET_PLATE = 4 }
-
 # Wire-format string to TileType mapping
 const TILE_TYPE_MAP: Dictionary = {
 	"floor": TileType.FLOOR,

client/scripts/rendering/world_renderer.gd

@@ -13,13 +13,13 @@ extends Node2D
 #     Overhead (Node2D)              — z:300 ceiling/upper structure (placeholder)
 #   FogOverlay (Node2D)              — z:900 fog shader (OUTSIDE FogGroup)
 
+var _last_tick: int = -1
+
 @onready var tile_renderer = $FogGroup/FloorTiles
 @onready var fog_renderer = $FogOverlay
 @onready var entity_renderer = $FogGroup/YSortGroup/Entities
 @onready var sound_indicator_renderer = $SoundIndicators  # #126 D-018 medium-range indicators
 
-var _last_tick: int = -1
-
 func _ready() -> void:
 	print("WorldRenderer: Initialized (D-049 z-stack)")