jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(simulation): remove duplicate TODO and dead binding in generator spike

Browse Source 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-03-07 08:48:20 +01:00
co-authored by Claude Opus 4.6
parent a54b9d24e0
commit 4b57006a5c
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/bin/generator_spike.rs
+1 -4
View File
@@ -295,9 +295,7 @@ const ALL_TRAITS: [PersonalityTrait; 10] = [
PersonalityTrait::Reclusive, PersonalityTrait::Reclusive,
]; ];
// TODO(integration): Duplicates `traits_contradict` from npc/generate.rs. // TODO(integration): duplicates the private `traits_contradict` in npc/generate.rs.
// Extract to a shared helper in npc/mod.rs when wiring the spike into the main pipeline.
// TODO(#612 integration): duplicates the private `traits_contradict` in npc/generate.rs.
// When wiring the spike into the main pipeline, expose that function as pub(crate) // When wiring the spike into the main pipeline, expose that function as pub(crate)
// and remove this copy. Kept separate for now to avoid spike coupling to ECS internals. // and remove this copy. Kept separate for now to avoid spike coupling to ECS internals.
fn traits_contradict(a: PersonalityTrait, b: PersonalityTrait) -> bool { fn traits_contradict(a: PersonalityTrait, b: PersonalityTrait) -> bool {
@@ -719,7 +717,6 @@ fn main() {
// Pre-generate unique names without replacement (#3 fix). // Pre-generate unique names without replacement (#3 fix).
// build_name_pool caps at pool size — actual count may be less than requested. // build_name_pool caps at pool size — actual count may be less than requested.
let name_pool = build_name_pool(&mut rng, &culture, npc_count); let name_pool = build_name_pool(&mut rng, &culture, npc_count);
let _npc_count = name_pool.len(); // use capped count (for documentation)
// First pass: generate all NPCs (no relationships yet) // First pass: generate all NPCs (no relationships yet)
let mut npcs: Vec<NpcBlueprint> = name_pool let mut npcs: Vec<NpcBlueprint> = name_pool