fix(ci): address PR review — filter comments, trim whitespace, warn on missing scripts
Address all review comments from Hoshe and Tyre on PR #27: - Remove 2>/dev/null from pre-pr-fixtures (critical: swallowed errors) - Remove dead _file_type function - Check 4: error on districts with no locations declared - Check 5: print advisory message when skipping - Check 8: cross-file line ID uniqueness (not just per-file) - Check 9: document D-034 asymmetric relationships in docstring - Document regex fallback rationale in _scan_knowledge - Add D-035 decision trace to schema descriptions - Use concrete protocol version in DEVOPS.md example - Amend D-035 with focused (9th mood) and greeting (14th situation) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
+1
-1
@@ -112,7 +112,7 @@ If `pre-pr-fixtures` fails, your protocol changes require fixture regeneration:
|
||||
```bash
|
||||
make fixtures
|
||||
git add client/tests/fixtures/
|
||||
git commit -m "chore(fixtures): regenerate for protocol vN"
|
||||
git commit -m "chore(fixtures): regenerate for protocol v8"
|
||||
```
|
||||
|
||||
The fixture staleness check is a **blocker** (exit 1) — stale fixtures cause false positive client tests.
|
||||
|
||||
Reference in New Issue
Block a user