fix(ci): address PR review — filter comments, trim whitespace, warn on missing scripts

Address all review comments from Hoshe and Tyre on PR #27:
- Remove 2>/dev/null from pre-pr-fixtures (critical: swallowed errors)
- Remove dead _file_type function
- Check 4: error on districts with no locations declared
- Check 5: print advisory message when skipping
- Check 8: cross-file line ID uniqueness (not just per-file)
- Check 9: document D-034 asymmetric relationships in docstring
- Document regex fallback rationale in _scan_knowledge
- Add D-035 decision trace to schema descriptions
- Use concrete protocol version in DEVOPS.md example
- Amend D-035 with focused (9th mood) and greeting (14th situation)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-18 00:23:21 +01:00
co-authored by Claude Opus 4.6
parent 06f47747c7
commit 4af2197c59
5 changed files with 35 additions and 24 deletions
+2 -2
View File
@@ -71,7 +71,7 @@
},
"minItems": 1,
"uniqueItems": true,
"description": "Situation contexts when this line can fire (D-035: list<enum>)"
"description": "Situation contexts when this line can fire (D-035: list<enum>). greeting added Sprint 8 for PC dialogue pools"
},
"topic": {
"type": "array",
@@ -96,7 +96,7 @@
]
},
"uniqueItems": true,
"description": "Mood tags for selection weighting (D-035: list<enum>)"
"description": "Mood tags for selection weighting (D-035: list<enum>, v0.1 8 moods + focused added Sprint 8)"
},
"tags": {
"type": "array",