refactor(simulation): replace ad-hoc system ordering with TickPhase pipeline (#843)
10-phase linear pipeline: PreInput → Input → Movement → Simulation → Economy → Storyteller → Snapshot → PostSnapshot → Knowledge → TickAdvance. Each system assigned to exactly one phase via .in_set(TickPhase::X). Cross-phase .after()/.before() eliminated — only intra-phase ordering remains. Prevents schedule cycles by construction. SimulationPlugin refactored into sub-plugins by domain: - InputPlugin (player actions, interactions, dialogue dispatch) - MovementPlugin (pathfinding, movement validation, spatial indexing) - SocialPlugin (conversations, sound, voice enrichment, follow state) - EconomyPlugin (tâtonnement tick, IPC query serving) - TimePlugin (chunk streaming, news ticker, tick advancement) All other plugins (NPC, Knowledge, Perception, Storyteller, Settings, Bridge) updated to use TickPhase assignments instead of cross-plugin ordering constraints. BridgePlugin trimmed to bridge I/O concerns only. Part A of #843. Parts B (multi-threaded executor) and C (background workers) follow. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -29,22 +29,23 @@ pub struct KnowledgePlugin;
|
||||
|
||||
impl Plugin for KnowledgePlugin {
|
||||
fn build(&self, app: &mut App) {
|
||||
use crate::tick_phases::TickPhase;
|
||||
|
||||
app.init_resource::<KnowledgeEventQueue>()
|
||||
.init_resource::<ContradictionDetectedQueue>()
|
||||
.init_resource::<EntityRegistry>()
|
||||
.init_resource::<ContentEntityRegistry>()
|
||||
.init_resource::<DecayThresholds>()
|
||||
// Knowledge phase: process events and decay.
|
||||
// One-tick lag from snapshot is intentional — contradiction monologue
|
||||
// and relationship shifts read as natural reaction delay (~0.1s).
|
||||
.add_systems(
|
||||
Update,
|
||||
(
|
||||
// Runs after snapshot: contradiction monologue and relationship
|
||||
// shifts from KnowledgeGranted events lag by one tick (~0.1s).
|
||||
// Acceptable — the player perceives the contradiction on the
|
||||
// next snapshot, which reads as a natural reaction delay.
|
||||
events::process_knowledge_events
|
||||
.after(crate::perception::observer::compute_observer_snapshot),
|
||||
events::process_knowledge_events,
|
||||
events::decay_knowledge.after(events::process_knowledge_events),
|
||||
),
|
||||
)
|
||||
.in_set(TickPhase::Knowledge),
|
||||
);
|
||||
tracing::debug!("KnowledgePlugin initialized");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user