From 474b31b2140e2f1b3c2b5570b2a7ae0a7a11b155 Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Thu, 16 Apr 2026 12:39:46 +0200 Subject: [PATCH] fix(tooling): only log rejections when all attempts exhausted (#833) Individual dedup/blocklist/placeholder/empty rejections that recover on the next attempt are now silent. Only the skipped: summary line prints when all 5 attempts fail. Subprocess errors still print immediately (those indicate a real problem). Co-Authored-By: Claude Opus 4.6 (1M context) --- tooling/planet-gen/gemma_naming.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tooling/planet-gen/gemma_naming.py b/tooling/planet-gen/gemma_naming.py index 24df3556e..f76205f90 100755 --- a/tooling/planet-gen/gemma_naming.py +++ b/tooling/planet-gen/gemma_naming.py @@ -1410,19 +1410,15 @@ def name_feature( cleaned = post_process(raw) if not cleaned: rejections["empty"] += 1 - log(f" empty {body_id}/{local_id} attempt {attempt}") continue if is_placeholder(cleaned): rejections["placeholder"] += 1 - log(f" placeholder '{cleaned}' {body_id}/{local_id}") continue if is_blocked(cleaned, blocklist): rejections["blocklist"] += 1 - log(f" blocklist '{cleaned}' {body_id}/{local_id}") continue if _is_duplicate(cleaned): rejections["dedup"] += 1 - log(f" dedup '{cleaned}' {body_id}/{local_id}") continue _commit_name(cleaned) return cleaned