jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ui): adapt client to new ui-strings.yaml structure

Browse Source 
The copy team rewrote ui-strings.yaml with multi-level nesting,
renamed sections, and inline comments. Update the YAML parser to
use a stack-based approach for arbitrary nesting depth, update HUD
and interaction prompt to reference the new key names, and align
tests with the new structure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-02-13 18:07:15 +01:00
co-authored by Claude Opus 4.6
parent 15ea6f1375
commit 470ec59b63
4 changed files with 92 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/tests/test_ui_strings.gd
+51 -5
View File
@@ -54,19 +54,59 @@ func test_parse_multiple_keys_per_section() -> void:
assert_that(result["hud.health"]).is_equal("Health")
# -- YAML parser: nested sections --
func test_parse_nested_sections() -> void:
var yaml := "states:\n unknown:\n label: \"Unknown\"\n description: \"No prior contact.\""
var result := UIStrings._parse_yaml(yaml)
assert_that(result.has("states.unknown.label")).is_true()
assert_that(result["states.unknown.label"]).is_equal("Unknown")
assert_that(result["states.unknown.description"]).is_equal("No prior contact.")
func test_parse_nested_multiple_subsections() -> void:
var yaml := "states:\n a:\n x: \"1\"\n b:\n x: \"2\""
var result := UIStrings._parse_yaml(yaml)
assert_that(result["states.a.x"]).is_equal("1")
assert_that(result["states.b.x"]).is_equal("2")
func test_parse_mixed_flat_and_nested() -> void:
var yaml := "hud:\n health: \"Condition\"\n health_values:\n full: \"Normal\"\n critical: \"Critical\""
var result := UIStrings._parse_yaml(yaml)
assert_that(result["hud.health"]).is_equal("Condition")
assert_that(result["hud.health_values.full"]).is_equal("Normal")
assert_that(result["hud.health_values.critical"]).is_equal("Critical")
func test_parse_inline_comment_quoted() -> void:
var yaml := "hud:\n prefix: \"\" # No prefix"
var result := UIStrings._parse_yaml(yaml)
assert_that(result.has("hud.prefix")).is_true()
assert_that(result["hud.prefix"]).is_equal("")
func test_parse_inline_comment_unquoted() -> void:
var yaml := "hud:\n mode: Standard # default mode"
var result := UIStrings._parse_yaml(yaml)
assert_that(result["hud.mode"]).is_equal("Standard")
func test_parse_quoted_empty_string() -> void:
var yaml := "section:\n key: \"\""
var result := UIStrings._parse_yaml(yaml)
assert_that(result.has("section.key")).is_true()
assert_that(result["section.key"]).is_equal("")
# -- Autoload: registration and file loading --
func test_autoload_registered() -> void:
assert_that(UIStrings).is_not_null()
func test_autoload_loaded_strings() -> void:
assert_that(UIStrings.has_key("hud.mode_label")).is_true()
assert_that(UIStrings.has_key("hud.health")).is_true()
func test_get_text_returns_value() -> void:
assert_that(UIStrings.get_text("hud.mode_label")).is_equal("Mode")
assert_that(UIStrings.get_text("hud.health")).is_equal("Condition")
func test_get_text_interaction_prefix() -> void:
assert_that(UIStrings.get_text("interaction.prompt_prefix")).is_equal("E")
func test_get_text_interaction_verb() -> void:
assert_that(UIStrings.get_text("interaction_verbs.talk")).is_equal("Talk")
func test_get_text_missing_key_returns_key() -> void:
var result := UIStrings.get_text("nonexistent.key")
@@ -76,7 +116,13 @@ func test_get_all_keys_not_empty() -> void:
assert_that(UIStrings.get_all_keys().size()).is_greater(0)
func test_has_key_true_for_existing() -> void:
assert_that(UIStrings.has_key("interaction.talk")).is_true()
assert_that(UIStrings.has_key("interaction_verbs.talk")).is_true()
func test_has_key_false_for_missing() -> void:
assert_that(UIStrings.has_key("nonexistent.key")).is_false()
func test_nested_key_exists() -> void:
assert_that(UIStrings.has_key("relationship_states.unknown.label")).is_true()
func test_nested_key_value() -> void:
assert_that(UIStrings.get_text("relationship_states.unknown.label")).is_equal("Unknown")