feat(simulation): cache TerrainAnalysis + derive basin_direction from the D8 thalweg (T-1044, T-1047)

T-1044: run_layer1 now returns TerrainAnalysis (carried transiently on
CascadeSnapshot, dropped after the district + road-graph passes), eliminating the
redundant per-body drainage::analyze + TerrainAnalysis::analyze re-run flagged by
PERF/TODO(T-1044). Not persisted on the LRU-cached state (D-203/T-1048 size concern).

T-1047: basin_direction is now derived from the real D8 thalweg. run_layer1
aggregates a per-district dominant D8 direction from the live fdir grid (carried
transiently on DrainageResult), threaded via Layer1Output.district_basin_dirs ->
derive_all_districts -> DistrictProfile.basin_direction; derive_chunk_context reads
it directly. Removed the false derive_basin_direction (it branched on ocean_fraction_q
then read seed bits despite a doc comment claiming an elev_q/slope_q D8 proxy) +
corrected the module contract. D-239 §8 (D8 thalweg) now actually honoured.

1559 tests pass; golden byte-identical (district_basin_dirs is #[serde(skip)], transient).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

server/tests/derivation_harness.rs

@@ -1930,6 +1930,7 @@ fn derive_profile_for_body(params: &BodyParams) -> DistrictProfile {
         &climate,
         "test_body",
         &BTreeMap::new(),
+        settled_reach_server::atlas::scale::BasinDirection::default(),
     )
 }
 
@@ -2265,6 +2266,7 @@ fn make_region(
         temperature_c,
         moisture_q,
         vegetation_class,
+        basin_direction: settled_reach_server::atlas::scale::BasinDirection::default(),
     }
 }
 

server/tests/gen_fixtures.rs

@@ -566,6 +566,7 @@ fn generate_atlas_layer_response_fixtures() {
         }],
         grid_w: 512,
         grid_h: 256,
+        district_basin_dirs: std::collections::BTreeMap::new(),
     };
     let ready = AtlasLayerResponse {
         body_id: "GJ1c".into(),