jpmschweitzerandClaude
f9e1409898
`make setup` created the venv and ran pip install, then exited 0 whether or not the result was usable — exactly D-24's failure shape, and the one this repo hit hardest: on 2026-08-09 there was no venv at all here while CLAUDE.md documented .venv/bin/python -m pytest as the way to run tests, and nothing in setup would have caught that state before a person did. Add a `pytest tests/ --collect-only -q` step at the end. It imports every test module and everything each one pulls in from src/, without running a single test, and fails the target on a broken interpreter or a broken dependency graph alike. Verified directly: - absent interpreter -> exit 127, target halts - apscheduler (declared, imported by src/main.py) uninstalled -> collect-only exits 4 with ModuleNotFoundError, target halts - make setup afterwards reinstalls it and collect-only exits 0, 189 tests collected, same count as before the mutation - idempotent: a warm rerun on an already-correct venv changes nothing and collects the same 189 tests, just faster (7s vs 30s cold) T-47 (workspace). Co-Authored-By: Claude <noreply@anthropic.com>
65 lines
2.9 KiB
Makefile
65 lines
2.9 KiB
Makefile
# scheduler — the repo's command surface (D-27).
|
|
#
|
|
# There is no venv in this working tree today, even though CLAUDE.md documents
|
|
# `.venv/bin/python -m pytest`. `make test` says so rather than failing with a
|
|
# bare "No such file or directory", and `make setup` creates one.
|
|
#
|
|
# `python3` on this host is 3.8; PYTHON names 3.12 explicitly (D-26).
|
|
|
|
VENV := $(CURDIR)/.venv
|
|
PYTHON ?= python3.12
|
|
|
|
.DEFAULT_GOAL := help
|
|
|
|
.PHONY: help
|
|
help: ## Show this help
|
|
@grep -hE '^[a-z][a-z0-9_-]*:.*?## ' $(MAKEFILE_LIST) \
|
|
| awk 'BEGIN{FS=":.*?## "}{printf " \033[36m%-14s\033[0m %s\n", $$1, $$2}'
|
|
|
|
.PHONY: setup
|
|
setup: ## Create the venv, install the test extra, and prove it actually works
|
|
$(PYTHON) -m venv .venv
|
|
$(VENV)/bin/pip install -e ".[test]"
|
|
@# Exit 0 from `pip install` is not evidence (D-24) — pip reports success even
|
|
@# when the result is unusable. Prove the environment works instead of trusting
|
|
@# the install step: `--collect-only` imports every test module and therefore
|
|
@# every src module each one pulls in, which is exactly the failure mode this
|
|
@# target exists to catch (T-47 — this repo had no venv at all on 2026-08-09,
|
|
@# and the documented test command could not work). It runs zero tests, so it
|
|
@# stays cheap, and unlike a bare `import src.main` it exercises the tests/
|
|
@# tree too, not just the package.
|
|
$(VENV)/bin/python -m pytest tests/ --collect-only -q
|
|
|
|
.PHONY: test
|
|
test: ## Run the test suite
|
|
@test -x $(VENV)/bin/python || { echo "FAIL — no venv in this tree; run: make setup"; exit 69; }
|
|
$(VENV)/bin/python -m pytest tests/
|
|
|
|
# No `lint` target, deliberately. CLAUDE.md states it outright: no linter is
|
|
# configured, no ruff or flake8 config, neither in the dependencies. Per D-27
|
|
# the name is reserved for repos that lint rather than mandated everywhere — a
|
|
# target here could only fail or report clean for something never run.
|
|
|
|
# git hands a hook a non-login shell, which never sees ~/.local/bin — where
|
|
# gitleaks lands. Without this the scan reports "not installed" on every push,
|
|
# which is a check that fails open (D-24).
|
|
export PATH := $(HOME)/.local/bin:/usr/local/bin:$(PATH)
|
|
|
|
.PHONY: secrets
|
|
secrets: ## Scan the commits about to be pushed for credentials
|
|
@ci/secrets.sh
|
|
|
|
# The call surface is identical in every repo; what it runs is not.
|
|
#
|
|
# `secrets` runs first, deliberately: it is the only failure here that cannot be
|
|
# undone by fixing it afterwards. A failed lint costs another commit; a pushed
|
|
# credential is cached and indexed whether or not it is later deleted.
|
|
#
|
|
# Some of these fail today, and are left wired anyway. The state was measured
|
|
# once and written down in T-56 rather than being worked around here — a gate
|
|
# quietly narrowed to what already passes is a gate that reports success for
|
|
# doing nothing, which is the failure this workspace keeps rediscovering.
|
|
.PHONY: pre-push
|
|
pre-push: secrets ## Everything the pre-push hook runs
|
|
@echo " -- not gated here yet: lint (no linter configured) and test (T-56)"
|