4 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude	3572a45322	test: delete six tests for a method that never existed ... _should_run_now has no definition in src/ in any commit in this repo's history — checked with `git log --all -S` across the whole tree, not just the current worktree. Twelve assertion sites across six tests called it, so these have never passed and never protected anything. The behaviour they describe is real: cron-wildcard matching of minute, hour, day_of_month, month and day_of_week. It lives inside the WHERE clause of get_tasks_for_minute, not as a Python predicate, so there was nothing to rename them onto. KNOWN GAP, stated rather than left implied: that matching is now covered by no test at all. Testing it means either asserting against the SQL and params a mocked cursor receives, or extracting the predicate out of the query — the second changes what decides, every minute, which scheduled work runs, and is not a refactor to do casually. Deleting was chosen over rewriting because a test that has never run is not coverage, and leaving it in place claimed some. Co-Authored-By: Claude <noreply@anthropic.com>	2026-08-18 20:44:08 +02:00
jpmschweitzer	6915be31ca	fix(tests): match postgres_host assertion to the fixture actually in effect ... tests/conftest.py sets os.environ["POSTGRES_HOST"] = "postgres-shared" at module level (before `from src.main import app`), commented "Use real postgres for integration tests". test_settings_loads_from_environment asserted settings.postgres_host == "test-postgres", a value grep confirms nothing in this suite has ever set — git log -p shows both the conftest line and this assertion originate in the same single commit and neither has changed since. Matched the assertion to the environment the suite actually runs under. Not a source change and not a claim that "postgres-shared" is the right fixture value for a suite this ticket also found is not actually hermetic where that value is concerned (see the 12 pre-existing DNS errors, tracked separately from this fix) — only that the assertion should test what the fixture sets, not an unset value.	2026-08-18 15:50:45 +02:00
jpmschweitzer	3f987bcf64	fix(tests): repair test_create_list_delete_task_flow's two defects ... Same dependency_overrides fix as the other test_*.py commits for get_task_executor (patch() cannot reach a route's already-registered Depends() reference — see the conftest.py commit for the full explanation and the empirical check that established it). Once the mock actually intercepted the DB layer, a second, independent defect surfaced: KeyError: 0. mock_cursor.fetchone.side_effect held 3 values sized for "create, list, delete" (one fetchone() each), but list_tasks uses fetchall(), not fetchone(), and delete_task has grown a second fetchone() call since this test was written — c34db66 added the 409-on-history-loss check, which does `row = cur.fetchone()` for the task id and then a separate `cur.fetchone()[0]` for its execution count. A real create->list-> delete flow through this endpoint set needs 1 (create) + 2 (delete) = 3 fetchone() values in that order, not one per named step. Re-sequenced so delete_task sees a real id and a zero execution count, reaching the intended 200 rather than an unhandled KeyError. Source unchanged; delete_task's behavior is deliberate (c34db66) and this integration test had not been updated to track it.	2026-08-18 15:50:29 +02:00
jpmschweitzerandClaude Opus 4.5	64574bcc39	Initial commit: scheduler service extraction from portainer-core ... Extracted standalone scheduler service with: - FastAPI REST API for task management - APScheduler-based task execution - PostgreSQL persistence - Docker container support - Gitea Actions CI/CD workflow 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2025-12-11 11:59:32 +01:00