Files
odysseus/tests/browser/notesOffline.mjs
T
Alexandre TeixeiraandLéo f1a47f3812 refactor(notes): decompose Notes into feature-owned modules (#6713)
* refactor(notes): decompose Notes into feature-owned modules

* fix(notes): avoid HTML interpolation in reminder picker

* docs(notes): drop checkpoint archives, session logs and publication drafts

The N0-N6 tarballs and raw pytest/node logs are not read by any script or
test, and the logs carry absolute home-directory paths. Once squashed into
dev they would stay in history for good. notes-pr.md and notes-issue.md
were the drafts used to open #6712 and #6713, not documentation.

notes-validation.md keeps the counts, the checkpoint hashes and
implementation.sha256 as the record; local interpreter paths and the local
Docker image name are replaced with portable placeholders.

* fix(notes): keep the state store raw and stop masonry re-observing after close

- state: writes built from views (filter, spread, splice) stored nested
  read-only views in the store, so structuredClone on a stored note threw
  DataCloneError. Store writes now unwrap nested views.
- layout: a save that resolves after closePanel re-renders the leaving pane
  and re-created the masonry ResizeObserver that teardown had disposed.
  Skip creating it once Notes is closed.
- index.js: drop 30 imported or declared names that were never used and
  group the imports at the top. Import order is unchanged.
- Revert unrelated punctuation edits in .gitattributes and keep the header
  comment and docstring first in compare/vote.js and
  test_notes_dom_xss_helpers.py.

Both fixes have a node test that fails on the previous head.

* test(notes): make script rejection assertion case-insensitive

Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum.

---------

Co-authored-by: Léo <leograndcontact@gmail.com>
2026-10-15 09:29:41 +01:00

40 lines
2.2 KiB
JavaScript

import assert from 'node:assert/strict';
import { chromium } from 'playwright';
import fs from 'node:fs';
const origin = process.env.ODYSSEUS_TEST_STATIC_ORIGIN;
const manifest = JSON.parse(fs.readFileSync(new URL('../../frontend/modules.json', import.meta.url), 'utf8'));
const outputs = manifest.modules.map(entry => '/static/' + entry.deployment);
const browser = await chromium.launch({ headless: true });
try {
const context = await browser.newContext({ serviceWorkers: 'allow' });
const page = await context.newPage();
await page.goto(`${origin}/static/js/panels.js`);
const cached = await page.evaluate(async outputs => {
await navigator.serviceWorker.register('/static/sw.js');
await navigator.serviceWorker.ready;
if (!navigator.serviceWorker.controller) await new Promise(resolve => navigator.serviceWorker.addEventListener('controllerchange', resolve, { once: true }));
const missing = [];
for (const output of outputs) if (!(await caches.match(output))?.ok) missing.push(output);
return missing;
}, outputs);
assert.deepEqual(cached, []);
assert.equal(await page.evaluate(async () => {
const shared = await import('/static/js/shared/ui/confetti.js');
const compare = await import('/static/js/compare/vote.js?v=20260828resendcaldrag1');
return shared.spawnConfetti === compare.spawnConfetti;
}), true);
await context.setOffline(true);
const offline = await context.newPage();
offline.on('requestfailed', request => console.log('offline failed:', request.url(), request.failure()));
offline.on('console', message => { if (message.type() === 'error') console.log('browser:', message.text()); });
await offline.goto(`${origin}/static/js/panels.js`);
const result = await offline.evaluate(async () => {
const facade = await import('/static/js/notes.js?v=20260911notesselectioncancel1');
const feature = await import('/static/js/features/notes/index.js');
return { identity: facade.default === feature.default && window.notesModule === feature.default, closed: facade.isPanelOpen() === false, exports: Object.keys(facade).sort() };
});
assert.equal(result.identity && result.closed, true);
console.log(JSON.stringify({ ...result, maintainedPrecache: outputs.length }));
} finally { await browser.close(); }