mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-15 11:22:21 +02:00
Alexandre TeixeiraandLéo
f1a47f3812
* refactor(notes): decompose Notes into feature-owned modules * fix(notes): avoid HTML interpolation in reminder picker * docs(notes): drop checkpoint archives, session logs and publication drafts The N0-N6 tarballs and raw pytest/node logs are not read by any script or test, and the logs carry absolute home-directory paths. Once squashed into dev they would stay in history for good. notes-pr.md and notes-issue.md were the drafts used to open #6712 and #6713, not documentation. notes-validation.md keeps the counts, the checkpoint hashes and implementation.sha256 as the record; local interpreter paths and the local Docker image name are replaced with portable placeholders. * fix(notes): keep the state store raw and stop masonry re-observing after close - state: writes built from views (filter, spread, splice) stored nested read-only views in the store, so structuredClone on a stored note threw DataCloneError. Store writes now unwrap nested views. - layout: a save that resolves after closePanel re-renders the leaving pane and re-created the masonry ResizeObserver that teardown had disposed. Skip creating it once Notes is closed. - index.js: drop 30 imported or declared names that were never used and group the imports at the top. Import order is unchanged. - Revert unrelated punctuation edits in .gitattributes and keep the header comment and docstring first in compare/vote.js and test_notes_dom_xss_helpers.py. Both fixes have a node test that fails on the previous head. * test(notes): make script rejection assertion case-insensitive Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum. --------- Co-authored-by: Léo <leograndcontact@gmail.com>
79 lines
2.5 KiB
JavaScript
79 lines
2.5 KiB
JavaScript
/** Notes CRUD, optimistic archive and in-memory undo workflows. */
|
|
export function createNotesWorkflows({
|
|
app,
|
|
api,
|
|
effects
|
|
}) {
|
|
const state = app.state;
|
|
const _undoStack = [];
|
|
const _renderNotes = effects.render;
|
|
const _patchNote = api.patchNote;
|
|
const uiModule = effects;
|
|
function _pushUndo(entry) {
|
|
_undoStack.push(entry);
|
|
if (_undoStack.length > 20) _undoStack.shift();
|
|
}
|
|
|
|
function _popAndRunUndo() {
|
|
const entry = _undoStack.pop();
|
|
if (entry) entry.run();
|
|
return !!entry;
|
|
}
|
|
|
|
function _undoArchive(note, prevIdx) {
|
|
// Re-insert at original position and clear archived flag on the server.
|
|
const safeIdx = Math.min(Math.max(prevIdx, 0), state.notes.length);
|
|
app.insertNoteAt(safeIdx, { ...note, archived: false });
|
|
_renderNotes();
|
|
_patchNote(note.id, { archived: false }).catch(() => {
|
|
// Roll back local insertion if the server refuses
|
|
const i = state.notes.findIndex(n => n.id === note.id);
|
|
if (i >= 0) app.removeNoteAt(i);
|
|
_renderNotes();
|
|
uiModule.showError('Undo failed');
|
|
});
|
|
}
|
|
|
|
function _archiveNoteById(id, { card = null, celebrate = false } = {}) {
|
|
if (!id) return false;
|
|
const idx = state.notes.findIndex(n => n.id === id);
|
|
if (idx < 0) return false;
|
|
const note = state.notes[idx];
|
|
if (celebrate && card && note) effects.celebrateArchive(note, card);
|
|
const removed = app.removeNoteAt(idx);
|
|
app.setEditingId(null);
|
|
_renderNotes();
|
|
const undo = () => _undoArchive(removed, idx);
|
|
_pushUndo({ label: 'archive', run: undo });
|
|
_patchNote(id, { archived: true }).then(() => {
|
|
effects.archived(undo);
|
|
}).catch(() => {
|
|
app.insertNoteAt(idx, removed);
|
|
_renderNotes();
|
|
uiModule.showError('Failed to archive');
|
|
});
|
|
return true;
|
|
}
|
|
|
|
async function _fetchNotes() {
|
|
app.setLoading(true);
|
|
try {
|
|
const res = await api.listNotes(state.showingArchived);
|
|
if (!res.ok) { app.replaceNotes([]); return; }
|
|
const data = await res.json();
|
|
app.replaceNotes(data.notes || data || []);
|
|
} catch (e) {
|
|
console.error('Failed to fetch notes:', e);
|
|
app.replaceNotes([]);
|
|
} finally {
|
|
app.setLoading(false);
|
|
}
|
|
}
|
|
|
|
function _saveNote(note) { return api.saveNote(note); }
|
|
|
|
function _deleteNoteApi(id) { return api.deleteNote(id); }
|
|
|
|
return { _pushUndo, _popAndRunUndo, _undoArchive, _archiveNoteById, _fetchNotes, _saveNote, _deleteNoteApi, _patchNote, undoCount: () => _undoStack.length };
|
|
}
|